Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package requests library with Windows installer to enable salt.util.http #21506

Closed
deuscapturus opened this issue Mar 10, 2015 · 2 comments
Closed
Labels
Duplicate Duplicate of another issue or PR - will be closed

Comments

@deuscapturus
Copy link
Contributor

I request the Windows Salt installer be repackaged to include the Requests library so that salt.util.http will work. Also set requests_lib: True.

@techhat
Copy link
Contributor

techhat commented Mar 10, 2015

So here's the deal @deuscapturus. Windows doesn't ship with a cert of SSL certificates that Python can use, like most Linux/Unix platforms do. Requests will provide this, but installing the certificates (and pointing Salt to them) will also provide this. I believe there is a version of the Windows installer out now that bundles requests (ping @UtahDave), but shipping the certs is more likely to be the solution going forward.

@rallytime rallytime added the Duplicate Duplicate of another issue or PR - will be closed label Mar 10, 2015
@rallytime
Copy link
Contributor

@deuscapturus I think this is technically a duplicate of #19969. Since that one has much more conversation and eyes, I am going to close this in favor of the older issue. If you disagree, please leave a comment and we can re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate Duplicate of another issue or PR - will be closed
Projects
None yet
Development

No branches or pull requests

3 participants