Turning everything into OrderedDicts broke states.keystone.user_present()

[0xf10e]

I think states.keystone.user_present() is broken in 2014.7.4 because this wasn't a problem before I updated to 2014.7.4:

          ID: cinder-user in Keystone
    Function: keystone.user_present
        Name: cinder
      Result: False
     Comment: An exception occurred in this state: Traceback (most recent call last):
                File "/usr/lib/python2.7/dist-packages/salt/state.py", line 1539, in call
                  **cdata['kwargs'])
                File "/var/cache/salt/minion/extmods/states/keystone.py", line 193, in user_present
                  for role in roles[tenant_role]:
              TypeError: list indices must be integers, not OrderedDict
     Started: 15:36:12.849284
    Duration: 101.783 ms
     Changes:   

So I hacked a tiny bit of debugging* into user_present() (just above line 180 and got this:

DEBUG: Roles for user "cinder": [OrderedDict([('service', ['admin'])])]

A list with a OrderedDict with a list with a tuple consisting of a string and a list with the string 'admin'?
Seems like the return of user_role_list() in modules.keystone changed quite a bit...

btw: I tried the keystone modules from branches develop and 2014.7.

*) And I suspect logging is broken, too, because I had to print to stderr...

[rallytime]

Thanks for the report and for the debugging! If you're able, we'd love a pull request addressing this issue. If not, that's ok, too. We can take a look.

[0xf10e]

Yesterday I was way too flabbergasted to know where to look. Now I understand the problem is a bit higher in the stacktrace: It's probably in salt/state.py where things changed. Thus using older versions of the keystone modules doesn't help.

But I won't touch this until Monday because I don't fiddle with OpenStack when not paid for ;)

[0xf10e]

OK, I'm getting closer! Current theory:
My states passed keystone.user_present() a list of roles instead a dict of roles.
I guess this worked with a list of dicts but not with a list of OrderedDicts.... we'll see.

[0xf10e]

See #22894 for the fix of the actually just minor problem.

[rallytime]

@0xf10e Awesome! Thanks very much for digging into this and for the fix!

[rallytime]

Since your fix was merged, I am going to close out this issue. If this pops up again, feel free to comment and we'll happily open this again. Thanks!