Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

salt artifactory.downloaded module ignore classifier #23370

Closed
lisa2lisa opened this issue May 5, 2015 · 4 comments
Closed

salt artifactory.downloaded module ignore classifier #23370

lisa2lisa opened this issue May 5, 2015 · 4 comments
Assignees
Labels
Bug broken, incorrect, or confusing behavior Documentation Relates to Salt documentation fixed-pls-verify fix is linked, bug author to confirm fix help-wanted Community help is needed to resolve this P4 Priority 4 RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Milestone

Comments

@lisa2lisa
Copy link
Contributor

salt --versions-report

           Salt: 2015.2.0rc2
         Python: 2.7.3 (default, Mar 13 2014, 11:03:55)
         Jinja2: 2.6
       M2Crypto: 0.21.1
 msgpack-python: 0.1.10
   msgpack-pure: Not Installed
       pycrypto: 2.6
        libnacl: Not Installed
         PyYAML: 3.10
          ioflo: Not Installed
          PyZMQ: 14.6.0
           RAET: Not Installed
            ZMQ: 3.2.3
           Mako: 0.7.0

salt-minion --version

salt-minion 2015.2.0rc2 (Lithium)

state.sls file

xxx_downloaded:
  artifactory.downloaded:
    - artifact:
        artifactory_url: http://xxx/artifactory
        repository: 'libs-release-local'
        artifact_id: 'test'
        group_id: 'com.xxx.tools'
        packaging: 'jar'
        classifier: 'all'
        version: '0.1.0'
    - target_dir: /tmp/

basing on the state.sls file, the following url is the jar you want to download:

http://xxx/artifactory/libs-release-local/com/xxx/tools/test/0.1.0/test-0.1.0-all.jar

but the actual download file is:

http://xxx/artifactory/libs-release-local/com/xxx/tools/test/0.1.0/test-0.1.0.jar

the debug info is following

[DEBUG   ] release_url=http://xxx/artifactory/libs-release-local/com/xxx/tools/xxx/0.1.0/xxx-0.1.0.jar
@jfindlay
Copy link
Contributor

jfindlay commented May 6, 2015

This seems to be yet another unfortunate consequence of us only giving attention to documentation on the develop branch. The classifier is available on develop but not 2015.2. We are working on a better documentation system, but I am not directly involved with that effort. It should be available in the next few months.

@jfindlay jfindlay added won't-fix legitimate issue, but won't fix info-needed waiting for more info and removed won't-fix legitimate issue, but won't fix labels May 6, 2015
@jfindlay jfindlay added this to the Blocked milestone May 6, 2015
@rallytime
Copy link
Contributor

If the classifier argument is only available on develop, then the docs should reflect that with a versionadded tag pointing to (in this case) Beryllium. I'm going to label this as a documentation fix.

@rallytime rallytime added Documentation Relates to Salt documentation Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around P4 Priority 4 and removed info-needed waiting for more info labels May 9, 2015
@rallytime rallytime modified the milestones: Approved, Blocked May 9, 2015
@rallytime rallytime added the help-wanted Community help is needed to resolve this label May 9, 2015
@rallytime
Copy link
Contributor

Oh, and the documentation effort that was mentioned above is being tracked in #12017.

@rallytime
Copy link
Contributor

I have fixed this documentation discrepancy in #27639.

@rallytime rallytime added the fixed-pls-verify fix is linked, bug author to confirm fix label Oct 2, 2015
@rallytime rallytime modified the milestones: B 11, Approved Oct 2, 2015
@rallytime rallytime self-assigned this Oct 2, 2015
@meggiebot meggiebot added the RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. label Oct 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Documentation Relates to Salt documentation fixed-pls-verify fix is linked, bug author to confirm fix help-wanted Community help is needed to resolve this P4 Priority 4 RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Projects
None yet
Development

No branches or pull requests

4 participants