Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contents_grains should have an example #23683

Closed
gravyboat opened this issue May 13, 2015 · 3 comments
Closed

contents_grains should have an example #23683

gravyboat opened this issue May 13, 2015 · 3 comments
Assignees
@rallytime
Labels
Bug broken, incorrect, or confusing behavior Documentation Relates to Salt documentation fixed-pls-verify fix is linked, bug author to confirm fix P4 Priority 4 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Milestone
B -3

Comments

@gravyboat
Copy link
Contributor

http://docs.saltstack.com/en/latest/ref/states/all/salt.states.file.html#salt.states.file.managed needs more data for contents_grains. While it's acceptable to say it behaves the same as contents_pillars, there's no reason to do that. We should copy paste the line from contents_grains (as well as the example), and make it relevant to grains. In addition we can add (similar to contents_pillar) at the end of the explanation prior to the example.
@rallytime
Copy link
Contributor

Good call @gravyboat!

@rallytime rallytime added Documentation Relates to Salt documentation Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around P4 Priority 4 labels May 13, 2015
@rallytime rallytime added this to the Approved milestone May 13, 2015
rallytime pushed a commit to rallytime/salt that referenced this issue Apr 28, 2016
Update contents_grains option with relevant docs
5184499 
Instead of "works like contents_pillar". Also added grains example.

Fixes saltstack#23683
@rallytime rallytime mentioned this issue Apr 28, 2016
Merged
@rallytime
Copy link
Contributor

@gravyboat I have fixed this in #32922. Look good?

@rallytime rallytime modified the milestones: B -3, Approved Apr 28, 2016
@rallytime rallytime self-assigned this Apr 28, 2016
@rallytime rallytime added TEAM Core fixed-pls-verify fix is linked, bug author to confirm fix labels Apr 28, 2016
@gravyboat
Copy link
Contributor Author

Looks great! Closing this out, thanks.

rallytime pushed a commit that referenced this issue Apr 28, 2016
Update contents_grains option with relevant docs (#32922)
31b96de 
Instead of "works like contents_pillar". Also added grains example.

Fixes #23683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rallytime rallytime

Labels
Bug broken, incorrect, or confusing behavior Documentation Relates to Salt documentation fixed-pls-verify fix is linked, bug author to confirm fix P4 Priority 4 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Projects
None yet
Milestone
B -3
Development

No branches or pull requests
2 participants
@gravyboat @rallytime