[ui] bash completion for the targeting with grains/pillars/etc.

[arthurzenika]

It would be quite cool to have some bash completion on the targeting part of the salt command. The completion could probably get it's information from the salt-key list (not the actual live state of the infrastructure for performance reasons).

I guess a first implementation would be on the glob syntax but we could imagine having a more complete implementation with nodegroups, regexp etc.

[arthurzenika]

For grains this could be useful too. I always forget if it is os_family or osfamily for example. Again using a cache for this would be preferable.

[jfindlay]

@arthurlogilab, thanks for the feature, this would be great.

[arthurzenika]

@jfindlay for glob, this is actually already implemented (don't know when, but 2014.7 has it). Updating the title.

For grains, typing tab tab after salt -G 'os:, shows a bunch of calls on the event bus, but ends of as salt -G 'os:' so I guess it's just trying to do the completion on available functions.

[alekibango]

hi, i am original author of completion, and i will try to fix it. What is really needed is good caching, as you noticed. Many functions are sluggish.

Low timeout value for reading list of grains (see /etc/bash_completion.d/salt-common, function _salt_get_grains) might even lead to empty list of grains on some systems. Increasing '--timeout 2' might make it work for you.

i will first try to add cache system, update list of available options and fix what is needed to make grains and pillars work well. it will take me some time, though, as it is not easy and I am under high load right now. Probably best will be to create unittesting environment and unittests... The completion is really hard to debug... If you would like to help, especially writing unittests, that would be great. Maybe like this.

[arthurzenika]

@alekibango first of all, thanks for the feature.

We'll try to put this in our todo list at some point. We don't really need this first hand, but might have a client that is interested in this. The unittest file from unity3d is a good source of inspiration indeed.

[alekibango]

I am very sorry, but i did not have time to move forward with this. My growing cloud took all of my time.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[arthurzenika]

+1 to keep this open

[stale]

Thank you for updating this issue. It is no longer marked as stale.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.