Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

salt/auth event should contain IP data #24580

Closed
clinta opened this issue Jun 10, 2015 · 4 comments
Closed

salt/auth event should contain IP data #24580

clinta opened this issue Jun 10, 2015 · 4 comments
Labels
Core relates to code central or existential to Salt Feature new functionality including changes to functionality and code refactors, etc. P3 Priority 3 Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged stale
Milestone

Comments

@clinta
Copy link
Contributor

clinta commented Jun 10, 2015

I'd like to create a reactor that automatically approves minions that come from my internal network. But the salt/auth event does not contain any network data. An IP field which contains the IP address that the request is coming from would allow approval based on networks.

@dmyerscough
Copy link
Contributor

@clinta Why not configure iptables to reject any communication with your master. You can filter based on your network range.

@cachedout
Copy link
Contributor

I'm not sure if we can get this data from ZeroMQ. We wouldn't want to rely on the minion to send it in the auth request, since it could be easily faked. We'll have to see what we can pull off the socket on the master side.

@cachedout cachedout added the Feature new functionality including changes to functionality and code refactors, etc. label Jun 11, 2015
@cachedout cachedout added this to the Blocked milestone Jun 11, 2015
@cachedout cachedout added the Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged label Jun 11, 2015
@clinta
Copy link
Contributor Author

clinta commented Jun 11, 2015

I don't believe there's a way at the network level to distinguish authorization requests form normal minion/master communication. I need minions from roaming laptops to be able to connect to the master over the internet.

@jfindlay jfindlay added Core relates to code central or existential to Salt P3 Priority 3 labels Aug 25, 2015
@stale
Copy link

stale bot commented Dec 22, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Dec 22, 2017
@stale stale bot closed this as completed Dec 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core relates to code central or existential to Salt Feature new functionality including changes to functionality and code refactors, etc. P3 Priority 3 Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged stale
Projects
None yet
Development

No branches or pull requests

4 participants