salt.states.file.copy does not copy the file if it already exists with force=True

[nmadhok]

Here's my state:

Revert to original /etc/sudoers:
  file.copy:
    - name: /etc/sudoers
    - source: /etc/sudoers.orig
    - user: root
    - group: root
    - mode: 0440
    - force: True
    - unless: diff /etc/sudoers /etc/sudoers.orig

Here's what I get when I run it:

----------
          ID: Revert to original /etc/sudoers
    Function: file.copy
        Name: /etc/sudoers
      Result: True
     Comment: The target file "/etc/sudoers" exists and will not be overwritten
     Started: 17:19:51.770100
    Duration: 8.963 ms
     Changes:   

This issue also exists in salt-enterprise-4.0.2:

           Salt: 4.0.2
         Python: 2.6.6 (r266:84292, Jan 22 2014, 01:49:05)
         Jinja2: 2.2.1
       M2Crypto: 0.20.2
 msgpack-python: 0.4.6
   msgpack-pure: Not Installed
       pycrypto: 2.6.1
        libnacl: Not Installed
         PyYAML: 3.10
          ioflo: Not Installed
          PyZMQ: 14.5.0
           RAET: Not Installed
            ZMQ: 4.0.5
           Mako: Not Installed

[tbaker57]

Duplicate of #24295 I think. Looks like this has already been fixed in develop: 0ff4366

cheers,
Tim

[jfindlay]

@nmadhok, thanks for the report.

[rallytime]

@nmadhok Does the fix in #254461 solve this one for you?

[nmadhok]

@rallytime Haven't tested it again and don't have the time to test this but looking at the change, it looks like it should fix it.

[rallytime]

I'm going to close this for now. If there's still trouble here, let us know and we can reopen. Thanks!