Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git state leaks HTTPS user/pw to log #26484

Closed
thusoy opened this issue Aug 19, 2015 · 1 comment
Closed

Git state leaks HTTPS user/pw to log #26484

thusoy opened this issue Aug 19, 2015 · 1 comment
Labels
Bug broken, incorrect, or confusing behavior P3 Priority 3 Platform Relates to OS, containers, platform-based utilities like FS, system based apps severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around State-Module
Milestone
Approved

Comments

@thusoy
Copy link
Contributor

thusoy commented Aug 19, 2015

Calling git.clone with https user/pass will leak the authentication details to the log.
@thusoy thusoy mentioned this issue Aug 19, 2015
Merged
@jfindlay jfindlay added Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around P3 Priority 3 Platform Relates to OS, containers, platform-based utilities like FS, system based apps State-Module labels Aug 20, 2015
@jfindlay jfindlay added this to the Approved milestone Aug 20, 2015
@jfindlay
Copy link
Contributor

@thusoy, thanks for the report and the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug broken, incorrect, or confusing behavior P3 Priority 3 Platform Relates to OS, containers, platform-based utilities like FS, system based apps severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around State-Module
Projects
None yet
Milestone
Approved
Development

No branches or pull requests
2 participants
@jfindlay @thusoy