Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salt-cloud Linode driver using RAM number for disk size #28118

Closed
basepi opened this issue Oct 19, 2015 · 1 comment
Closed

Salt-cloud Linode driver using RAM number for disk size #28118

basepi opened this issue Oct 19, 2015 · 1 comment
Assignees
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix P1 Priority 1 RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. Salt-Cloud severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Milestone

Comments

@basepi
Copy link
Contributor

basepi commented Oct 19, 2015

If I create a Linode VM with the following profile:

ubuntu-14.04:
  provider: linode-saltstack
  size: Linode 1024
  image: Ubuntu 14.04 LTS
  location: Atlanta, GA, USA

The disk size is much smaller than the total 24GB it should be:

root@li1316-29:~# df -h
Filesystem      Size  Used Avail Use% Mounted on
/dev/sda        818M  759M   35M  96% /
none            4.0K     0  4.0K   0% /sys/fs/cgroup
devtmpfs        494M  4.0K  494M   1% /dev
none            100M  308K   99M   1% /run
none            5.0M     0  5.0M   0% /run/lock
none            496M     0  496M   0% /run/shm
none            100M     0  100M   0% /run/user

I think it's due to this line: https://github.com/saltstack/salt/blob/2015.8/salt/cloud/clouds/linode.py#L757

We need to fetch the actual disk size for the VM. Possibly TOTALHD from https://www.linode.com/api/linode/linode.list or just convert the DISK from https://www.linode.com/api/utility/avail.linodeplans into MB?

@basepi basepi added Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around Salt-Cloud P1 Priority 1 RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. labels Oct 19, 2015
@basepi basepi added this to the B 10 milestone Oct 19, 2015
rallytime pushed a commit to rallytime/salt that referenced this issue Oct 20, 2015
@rallytime
Copy link
Contributor

Thanks for finding this one @basepi. I've fixed it with #28141 by using the TOTALHD value from linode.list.

Tested, and confirmed that the disk looks happier:

root@rallytime:~# salt rally-01 cmd.run "df -h"
rally-01:
    Filesystem      Size  Used Avail Use% Mounted on
    /dev/sda         48G  960M   46G   3% /
    none            4.0K     0  4.0K   0% /sys/fs/cgroup
    devtmpfs        998M  4.0K  998M   1% /dev
    none            200M  312K  200M   1% /run
    none            5.0M     0  5.0M   0% /run/lock
    none           1000M   12K 1000M   1% /run/shm
    none            100M     0  100M   0% /run/user

@rallytime rallytime added the fixed-pls-verify fix is linked, bug author to confirm fix label Oct 20, 2015
@basepi basepi closed this as completed Oct 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix P1 Priority 1 RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. Salt-Cloud severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Projects
None yet
Development

No branches or pull requests

2 participants