Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2015.8] pkg breaks for yum pkgs.latest if the packages has an epoch #31014

Closed
gtmanfred opened this issue Feb 8, 2016 · 2 comments
Closed

[2015.8] pkg breaks for yum pkgs.latest if the packages has an epoch #31014

gtmanfred opened this issue Feb 8, 2016 · 2 comments
Assignees
@terminalmage
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix P2 Priority 2 Platform Relates to OS, containers, platform-based utilities like FS, system based apps Regression The issue is a bug that breaks functionality known to work in previous releases. severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around State-Module
Milestone
B 3

Comments

@gtmanfred
Copy link
Contributor

It looks like it will install the package, but when salt goes back and makes sure that the latest version is installed, it does not take into account that a version may have an epoch that is not displayed by yum for some reason.

The quickest example is for libguestfs-tools, which has an epoch of 1.

----------
          ID: nova packages
    Function: pkg.latest
      Result: False
     Comment: The following packages failed to update: libguestfs-tools The following packages were already up-to-date: openstack-nova-compute, sysfsutils
     Started: 19:08:39.658538
    Duration: 7961.173 ms
     Changes:
              ----------
              libguestfs-tools:
                  ----------
                  new:
                      1.28.1-1.55.el7.centos
                  old:

[root@novacompute01 ~]# yum list installed | grep libguestfs-tools
libguestfs-tools.noarch 1:1.28.1-1.55.el7.centos @base
libguestfs-tools-c.x86_64 1:1.28.1-1.55.el7.centos @base

So the versions do not match, because the version displayed when installing is without the epoch.

https://github.com/saltstack/salt/blob/develop/salt/states/pkg.py#L1598
@gtmanfred
Copy link
Contributor Author

@terminalmage ping :)

@gtmanfred gtmanfred mentioned this issue Feb 8, 2016
Merged
gtmanfred added a commit to gtmanfred/salt that referenced this issue Feb 8, 2016
@gtmanfred
include possible epoch in version for rpm
e1211ed 
Fixes saltstack#31014
@jfindlay jfindlay added Execution-Module Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around P2 Priority 2 Platform Relates to OS, containers, platform-based utilities like FS, system based apps State-Module fixed-pls-verify fix is linked, bug author to confirm fix and removed Execution-Module labels Feb 8, 2016
@jfindlay jfindlay added this to the Approved milestone Feb 8, 2016
@terminalmage terminalmage mentioned this issue Feb 9, 2016
Merged
@terminalmage terminalmage added Regression The issue is a bug that breaks functionality known to work in previous releases. TEAM Core labels Feb 9, 2016
@terminalmage terminalmage modified the milestones: B 3, Approved Feb 9, 2016
@terminalmage terminalmage self-assigned this Feb 9, 2016
cachedout pushed a commit that referenced this issue Feb 9, 2016
Merge pull request #31031 from terminalmage/issue31014
071b9d4 
More complete fix for #31014
@cachedout
Copy link
Contributor

Fixed via #31031

terminalmage pushed a commit to terminalmage/salt that referenced this issue Feb 10, 2016
@gtmanfred @terminalmage
include possible epoch in version for rpm
ed74627 
Fixes saltstack#31014
Ch3LL added a commit to Ch3LL/salt that referenced this issue Feb 11, 2016
@Ch3LL
integration test for issue saltstack#31014
af82b12
cachedout pushed a commit that referenced this issue Feb 11, 2016
Merge pull request #31131 from Ch3LL/megan-20158
b831e0a 
integration test for issue #31014
This was referenced Feb 26, 2016
Closed
Closed
@asnell asnell mentioned this issue Jun 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terminalmage terminalmage

Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix P2 Priority 2 Platform Relates to OS, containers, platform-based utilities like FS, system based apps Regression The issue is a bug that breaks functionality known to work in previous releases. severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around State-Module
Projects
None yet
Milestone
B 3
Development

No branches or pull requests
4 participants
@cachedout @terminalmage @jfindlay @gtmanfred