Salt Cloud 2015.8.8 not installing salt minions on new nodes

[llamallama]

Description of Issue/Question

After upgrading from 2015.8.7 to 2015.8.8, salt-cloud no longer deployments the minions to newly provisioned nodes. My test case is with Linode, but I've heard reports on IRC of the same issue with Digital Ocean on the same salt version.

Setup

Provider:

linode-config:
  apikey: xxxx
  ssh_key_file: /etc/salt/cloud.keys.d/salt_linode_rsa
  password: xxxx
  driver: linode
  minion:
    master: salt
  grains:
    environment: internal
    location: linode
    roles:
      - zabbix-agent
  startup_states: highstate

Profile

linode_1024_GA:
  provider: linode-config
  password: xxxx
  size: Linode 1024
  image: CentOS 7
  location: Atlanta, GA, USA
  private_ip: false
linode_2048_GA:
  provider: linode-config
  password: xxxx
  size: Linode 2048
  image: CentOS 7
  location: Atlanta, GA, USA
  private_ip: false
linode_1024_NJ:
  provider: linode-config
  password: xxxx
  size: Linode 1024
  image: CentOS 7
  location: Newark, NJ, USA
  private_ip: false
linode_2048_NJ:
  provider: linode-config
  password: xxxx
  size: Linode 2048
  image: CentOS 7
  location: Newark, NJ, USA
  private_ip: false
linode_1024_TX:
  provider: linode-config
  password: xxxx
  size: Linode 1024
  image: CentOS 7
  location: Dallas, TX, USA
  private_ip: false
linode_2048_TX:
  provider: linode-config
  password: xxxx
  size: Linode 2048
  image: CentOS 7
  location: Dallas, TX, USA
  private_ip: false

Steps to Reproduce Issue

salt-cloud -p linode_1024_GA cloudtest --keep-tmp

It creates the Linode instance and returns this when completed.

cloudtest:
    ----------
    deployed:
        True
    id:
        1751789
    image:
        CentOS 7
    name:
        cloudtest
    private_ips:
    public_ips:
        - XX.XX.XX.XX
    size:
        Linode 1024
    state:
        Running

I SSHed into the node and salt that salt was not installed and the deployment script never ran. With the --keep-tmp flag, I noticed that the pem files did get placed but not deploy.sh.

Versions Report

Salt Version:
           Salt: 2015.8.8

Dependency Versions:
         Jinja2: 2.7.2
       M2Crypto: 0.21.1
           Mako: Not Installed
         PyYAML: 3.11
          PyZMQ: 14.7.0
         Python: 2.7.5 (default, Nov 20 2015, 02:00:19)
           RAET: Not Installed
        Tornado: 4.2.1
            ZMQ: 4.0.5
           cffi: Not Installed
       cherrypy: Not Installed
       dateutil: Not Installed
          gitdb: Not Installed
      gitpython: Not Installed
          ioflo: Not Installed
        libgit2: Not Installed
        libnacl: Not Installed
   msgpack-pure: Not Installed
 msgpack-python: 0.4.6
   mysql-python: Not Installed
      pycparser: Not Installed
       pycrypto: 2.6.1
         pygit2: Not Installed
   python-gnupg: Not Installed
          smmap: Not Installed
        timelib: Not Installed

System Versions:
           dist: centos 7.2.1511 Core
        machine: x86_64
        release: 4.4.0-x86_64-linode63
         system: CentOS Linux 7.2.1511 Core

[llamallama]

I got this to work by running
salt-cloud --update-bootstrap

I guess the deploy script somehow got removed during the update.

[iggy]

#28466
#26699

[llamallama]

Reopening since this was not supposed to happen.

[jfindlay]

@llamallama, @iggy, thanks for reporting.

[rallytime]

#31172 and #32105 might address this.

[frogunder]

I have not been able to replicate this.
I updated from 2015.8.7 to 2015.8.8.
When I created a new cloud, the bootstrap script in /etc/salt/cloud.deploy.d ran and salt got installed on the new cloud.

Provider:

linode:
  apikey: xxxx
  password: xxxx
  location: Fremont, CA, USA
  provider: linode

Profile:

linode_cent7:
  provider: linode
  size: Linode 2048
  image: CentOS 7

[iggy]

The issue is if you don't have the script in /etc/salt/cloud.deploy.d. It's supposed to fetch from elsewhere and that seems to fail under certain circumstances.

[frogunder]

Tested again without a script in /etc/salt/cloud.deploy.d.
I can confirm this is an error, like it is described above.

In 2015.8.7

[INFO    ] Rendering deploy script: /usr/lib/python2.7/site-packages/salt/cloud/deploy/bootstrap-salt.sh

Salt gets installed.

---

In 2015.8.8

It do not render the deploy script
Salt do not get installed.

[meggiebot]

#32105 was merged on the head of the branch, but our internal testing is still showing issues. We are investigating further.

[Ch3LL]

I have verified that this is fixed at the head of 2015.8. #32105 fixes this issue.