Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in states/virtualenv_mod.py #33565

Closed
jamesp9 opened this issue May 27, 2016 · 2 comments
Closed

Typo in states/virtualenv_mod.py #33565

jamesp9 opened this issue May 27, 2016 · 2 comments
Labels
Bug broken, incorrect, or confusing behavior P2 Priority 2 Platform Relates to OS, containers, platform-based utilities like FS, system based apps severity-critical top severity, seen by most users, serious issues severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around State-Module ZRELEASED - Boron
Milestone

Comments

@jamesp9
Copy link

jamesp9 commented May 27, 2016

Description of Issue/Question

Line 192 in "/usr/lib/python2.7/dist-packages/salt/states/virtualenv_mod.py"
formar(err) should be
format(err)

Steps to Reproduce Issue

Use the virtualenv.managed state to try and create a virtualenv environment.

----------
          ID: create_my_virtualenv
    Function: virtualenv.managed
        Name: venv
      Result: False
     Comment: An exception occurred in this state: Traceback (most recent call last):
                File "/usr/lib/python2.7/dist-packages/salt/state.py", line 1703, in call
                  **cdata['kwargs'])
                File "/usr/lib/python2.7/dist-packages/salt/loader.py", line 1649, in wrapper
                  return f(*args, **kwargs)
                File "/usr/lib/python2.7/dist-packages/salt/states/virtualenv_mod.py", line 192, in managed
                  ret['comment'] = 'Failed to create virtualenv: {0}'.formar(err)
              AttributeError: 'str' object has no attribute 'formar'

Versions Report

# salt --versions-report
Salt Version:
           Salt: 2016.3.0

Dependency Versions:
           cffi: Not Installed
       cherrypy: Not Installed
       dateutil: 2.4.2
          gitdb: 0.6.4
      gitpython: 1.0.1
          ioflo: Not Installed
         Jinja2: 2.8
        libgit2: Not Installed
        libnacl: Not Installed
       M2Crypto: Not Installed
           Mako: 1.0.3
   msgpack-pure: Not Installed
 msgpack-python: 0.4.6
   mysql-python: Not Installed
      pycparser: Not Installed
       pycrypto: 2.6.1
         pygit2: Not Installed
         Python: 2.7.11+ (default, Apr 17 2016, 14:00:29)
   python-gnupg: Not Installed
         PyYAML: 3.11
          PyZMQ: 15.2.0
           RAET: Not Installed
          smmap: 0.9.0
        timelib: Not Installed
        Tornado: 4.2.1
            ZMQ: 4.1.4

System Versions:
           dist: Ubuntu 16.04 xenial
        machine: x86_64
        release: 4.4.0-21-generic
         system: Linux
        version: Ubuntu 16.04 xenial
tomlaredo pushed a commit to rodacom/salt that referenced this issue May 27, 2016
cachedout pushed a commit that referenced this issue May 27, 2016
Fix #33565 (typo causes invalid syntax)
@Ch3LL
Copy link
Contributor

Ch3LL commented May 27, 2016

@jamesp9 thanks for pointing that out and what looks like the fix. 👍

@Ch3LL Ch3LL added P2 Priority 2 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around Platform Relates to OS, containers, platform-based utilities like FS, system based apps labels May 27, 2016
@Ch3LL Ch3LL added this to the Approved milestone May 27, 2016
@Ch3LL Ch3LL added Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around State-Module severity-critical top severity, seen by most users, serious issues ZRELEASED - Boron and removed severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around labels May 27, 2016
@cachedout
Copy link
Contributor

We already merged a fix for this in #33565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior P2 Priority 2 Platform Relates to OS, containers, platform-based utilities like FS, system based apps severity-critical top severity, seen by most users, serious issues severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around State-Module ZRELEASED - Boron
Projects
None yet
Development

No branches or pull requests

3 participants