ini_manage.options_absent: only works in test mode (TypeError: unhashable type: 'list')

[morganwillcock]

cleanup_usbdlm_configuration:
  ini.options_absent:
    - name: {{ program_files }}\USBDLM\USBDLM.ini
    - sections:
        DriveLetters:
          - Letters

Everything still looks okay when testing state:
salt salt-test state.apply test=True

----------
          ID: cleanup_usbdlm_configuration
    Function: ini.options_absent
        Name: C:\Program Files\USBDLM\USBDLM.ini
      Result: True
     Comment: Key Letters in section DriveLetters does not exist.
     Started: 17:21:01.656000
    Duration: 0.0 ms
     Changes:   
----------

...but actually applying it no longer works:
salt salt-test state.apply

----------
          ID: cleanup_usbdlm_configuration
    Function: ini.options_absent
        Name: C:\Program Files\USBDLM\USBDLM.ini
      Result: False
     Comment: An exception occurred in this state: Traceback (most recent call last):
                File "C:\salt\bin\lib\site-packages\salt\state.py", line 1703, in call
                  **cdata['kwargs'])
                File "C:\salt\bin\lib\site-packages\salt\loader.py", line 1649, in wrapper
                  return f(*args, **kwargs)
                File "C:\salt\bin\lib\site-packages\salt\states\ini_manage.py", line 113, in options_absent
                  current_value = __salt__['ini.remove_option'](name, section, key)
                File "C:\salt\bin\lib\site-packages\salt\modules\ini_manage.py", line 124, in remove_option
                  value = inifile.get(section, {}).pop(option, None)
                File "C:\salt\bin\lib\collections.py", line 143, in pop
                  if key in self:
              TypeError: unhashable type: 'list'
     Started: 17:22:59.435000
    Duration: 16.0 ms
     Changes:   
----------

This was working fine on 2015.8.8-2 and 2015.8.10, but seems to be broken after upgrade to 2016.3.0

[Ch3LL]

@morganwillcock i'm also seeing the same thing on centos7:

local:
----------
          ID: /tmp/test.ini
    Function: ini.options_absent
      Result: False
     Comment: An exception occurred in this state: Traceback (most recent call last):
                File "/home/ch3ll/git/salt/salt/state.py", line 1703, in call
                  **cdata['kwargs'])
                File "/home/ch3ll/git/salt/salt/loader.py", line 1649, in wrapper
                  return f(*args, **kwargs)
                File "/home/ch3ll/git/salt/salt/states/ini_manage.py", line 113, in options_absent
                  current_value = __salt__['ini.remove_option'](name, section, key)
                File "/home/ch3ll/git/salt/salt/modules/ini_manage.py", line 125, in remove_option
                  inifile = _Ini.get_ini_file(file_name)
                File "/usr/lib64/python2.7/collections.py", line 138, in pop
                  if key in self:
              TypeError: unhashable type: 'list'
     Started: 17:08:07.909619
    Duration: 10673.034 ms
     Changes:   

Summary for local
------------
Succeeded: 0
Failed:    1
------------
Total states run:     1

test=True:

local:
----------
          ID: /tmp/test.ini
    Function: ini.options_absent
      Result: True
     Comment: Key OrderedDict([('ConfirmFileOp', 0)]) in section .ShellClassInfo does not exist.
     Started: 17:08:34.215833
    Duration: 1.794 ms
     Changes:   

Summary for local
------------
Succeeded: 1
Failed:    0
------------
Total states run:     1

Looks like this needs to get fixed. Thanks

[danslimmon]

This was broken in 7ac43c7. Working on a fix.

[rallytime]

@morganwillcock This should be fixed by #33606. Do you have a moment to give that a try and confirm this is fixed?

[morganwillcock]

@rallytime That fixes it for me, thank you.

----------
          ID: cleanup_usbdlm_configuration
    Function: ini.options_absent
        Name: C:\Program Files\USBDLM\USBDLM.ini
      Result: True
     Comment: No anomaly detected
     Started: 17:28:47.266000
    Duration: 11.0 ms
     Changes:
----------

[rallytime]

@morganwillcock Great! Thanks for confirming.