-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
file.managed state should not download a file if the checksum did not change #33831
Comments
I have also begun to notice this, and was just about to submit the same issue. My versions-report:
|
It appears that this behavior is also present for |
This behavior was working correctly in |
The behavior is also correct in |
Behavior is also correct in So regression appears to have been introduced between |
I am able to replicate this behavior. @timcharper thanks for the investigation work it made for much speedier tests. Looks like the break was caused by this PR: #31265 Even when adding the new argument this issue also might be related: #33575 ping @terminalmage |
The fix was made in the 2015.8 release branch and merged forward as we typically do for bugfixes. The merge forward may not have fully propagated this fix, however. I'll look at this on Thursday. |
I've opened #34010 to fix this. |
This bug is still in 2017.7.0 version! |
@ata-sql Since this issue has been closed for over a year, please file a new issue with the relevant information and version report. |
When using the
file.managed
state with a HTTP URL and a providedsource_hash
I would expect Salt to check the hash of an existing local file before downloading the file from the server.This seems like a regression to me because in older versions (just tested with
salt-call 0.17.5
) the file is only downloaded once. After that, the log just printsFile ... is in the correct state
Setup
Salt Version: 2016.3.0 (Boron) - in masterless local mode
Ubuntu 14.04 trusty
Salt config / log output: https://gist.github.com/astehlik/adb8e284cd8974cba0bd2858c5bb038b
Steps to Reproduce Issue
salt-call state.highstate
salt-call state.highstate
again, file is downloaded againVersions Report
Working version
Broken version
The text was updated successfully, but these errors were encountered: