Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saltutil.wheel minions.connected does not return anything with remote minions #33879

Closed
Ch3LL opened this issue Jun 8, 2016 · 1 comment
Closed
Assignees
Labels
Bug broken, incorrect, or confusing behavior Core relates to code central or existential to Salt Execution-Module fixed-pls-verify fix is linked, bug author to confirm fix P4 Priority 4 severity-low 4th level, cosemtic problems, work around exists
Milestone

Comments

@Ch3LL
Copy link
Contributor

Ch3LL commented Jun 8, 2016

Description of Issue/Question

On the head of 2016.3 when testing the fix for issue #32446 there is no return for remote minions. I am expecting the following error: ERROR: This command can only be executed on a minion that is located on the master.

Setup

  1. 2 minioins connected to a master. One of them local and one of them remote

Steps to Reproduce Issue

  1. run the following: salt '*' saltutil.wheel minions.connected
  2. And you will see that the remote minion does not return anything:
root@ip-10-95-162-59:~/salt# salt '*' saltutil.wheel minions.connected -lwarning
masterminion:
    - masterminion
    - remoteminion
remoteminion:

Versions Report

root@ip-10-95-162-59:~/salt# salt --versions-report
Salt Version:
           Salt: 2016.3.0-47-gbe20ce1

Dependency Versions:
           cffi: Not Installed
       cherrypy: Not Installed
       dateutil: Not Installed
          gitdb: Not Installed
      gitpython: Not Installed
          ioflo: Not Installed
         Jinja2: 2.8
        libgit2: Not Installed
        libnacl: Not Installed
       M2Crypto: Not Installed
           Mako: Not Installed
   msgpack-pure: Not Installed
 msgpack-python: 0.4.7
   mysql-python: Not Installed
      pycparser: Not Installed
       pycrypto: 2.6.1
         pygit2: Not Installed
         Python: 2.7.6 (default, Jun 22 2015, 17:58:13)
   python-gnupg: Not Installed
         PyYAML: 3.10
          PyZMQ: 15.2.0
           RAET: Not Installed
          smmap: Not Installed
        timelib: Not Installed
        Tornado: 4.3
            ZMQ: 4.1.2

System Versions:
           dist: Ubuntu 14.04 trusty
        machine: x86_64
        release: 3.13.0-36-generic
         system: Linux
        version: Ubuntu 14.04 trusty
@Ch3LL Ch3LL added Bug broken, incorrect, or confusing behavior P4 Priority 4 severity-low 4th level, cosemtic problems, work around exists Core relates to code central or existential to Salt labels Jun 8, 2016
@Ch3LL Ch3LL added this to the Approved milestone Jun 8, 2016
@rallytime rallytime modified the milestones: C 8, Approved Jun 9, 2016
@rallytime
Copy link
Contributor

After reviewing the changes in this code from 2015.8 to 2016.3, the remote minion no longer throws a SaltInvocationError when attempting to run wheel commands as it did in 2015.8. Instead of throwing the error, the remote minion returns as "empty".

For example, a saltutil.wheel minions.connected command returns an empty list. While this is a correct return, and is expected behavior for a remote minion - it wouldn't have any minions connected to it, it is not necessarily obvious of why this return is empty.

@Ch3LL and I spoke offline about this and agreed that the solution to this bug is better documentation, as submitted in #34214.

@rallytime rallytime added fixed-pls-verify fix is linked, bug author to confirm fix TEAM Core labels Jun 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Core relates to code central or existential to Salt Execution-Module fixed-pls-verify fix is linked, bug author to confirm fix P4 Priority 4 severity-low 4th level, cosemtic problems, work around exists
Projects
None yet
Development

No branches or pull requests

2 participants