States mount.* fail on OpenBSD's tmpfs #34012

viq · 2016-06-14T19:50:49Z

States mount.* fail to take into consideration `mount` output on OpenBSD

Setup

Latest OpenBSD snapshot (doesn't matter, should behave the same on any). Following state:

secrets storage:
  mount.mounted:
    - name: /etc/secrets
    - device: tmpfs
    - fstype: tmpfs
    - opts: rw,-s20M,-uroot,-gwheel,-m0700
    - dump: 0
    - pass_num: 0
    - persist: True
    - mkmnt: True

Which results in following fstab entry:

tmpfs           /etc/secrets    tmpfs   rw,-s20M,-uroot,-gwheel,-m0700  0 0

and following mount -v output:

tmpfs on /etc/secrets type tmpfs (rw, local, ctime=Tue Jun 14 20:32:02 2016)

Steps to Reproduce Issue

$ sudo salt-call -l debug --local mount.active 
[DEBUG   ] Reading configuration from /etc/salt/minion
[DEBUG   ] Including configuration from '/etc/salt/minion.d/_schedule.conf'
[DEBUG   ] Reading configuration from /etc/salt/minion.d/_schedule.conf
[DEBUG   ] Including configuration from '/etc/salt/minion.d/startup_states.conf'
[DEBUG   ] Reading configuration from /etc/salt/minion.d/startup_states.conf
[DEBUG   ] Using cached minion ID from /etc/salt/minion_id: builder.viq.vc
[DEBUG   ] Configuration file path: /etc/salt/minion
[WARNING ] Insecure logging configuration detected! Sensitive data may be logged.
[DEBUG   ] Reading configuration from /etc/salt/minion
[DEBUG   ] Including configuration from '/etc/salt/minion.d/_schedule.conf'
[DEBUG   ] Reading configuration from /etc/salt/minion.d/_schedule.conf
[DEBUG   ] Including configuration from '/etc/salt/minion.d/startup_states.conf'
[DEBUG   ] Reading configuration from /etc/salt/minion.d/startup_states.conf
[DEBUG   ] Please install 'virt-what' to improve results of the 'virtual' grain.
[DEBUG   ] Determining pillar cache
[DEBUG   ] LazyLoaded jinja.render
[DEBUG   ] LazyLoaded yaml.render
[DEBUG   ] LazyLoaded jinja.render
[DEBUG   ] LazyLoaded yaml.render
[DEBUG   ] LazyLoaded mount.active
[DEBUG   ] LazyLoaded cmd.run_stdout
[INFO    ] Executing command 'mount -v' in directory '/home/viq'
[DEBUG   ] stdout: /dev/sd0a (bd15538f0bff9935.a) on / type ffs (rw, local, softdep, ctime=Tue Jun 14 20:32:10 2016)
/dev/sd0k (bd15538f0bff9935.k) on /home type ffs (rw, NFS exported, local, nosuid, softdep, ctime=Tue Jun 14 20:32:10 2016)
/dev/sd0d (bd15538f0bff9935.d) on /tmp type ffs (rw, local, nodev, nosuid, softdep, ctime=Tue Jun 14 20:32:10 2016)
/dev/sd0f (bd15538f0bff9935.f) on /usr type ffs (rw, local, nodev, softdep, ctime=Tue Jun 14 20:32:10 2016)
/dev/sd0g (bd15538f0bff9935.g) on /usr/X11R6 type ffs (rw, local, nodev, softdep, ctime=Tue Jun 14 20:32:11 2016)
/dev/sd0h (bd15538f0bff9935.h) on /usr/local type ffs (rw, local, nodev, wxallowed, softdep, ctime=Tue Jun 14 20:32:11 2016)
/dev/sd0j (bd15538f0bff9935.j) on /usr/obj type ffs (rw, local, nodev, nosuid, softdep, ctime=Tue Jun 14 20:32:11 2016)
/dev/sd0i (bd15538f0bff9935.i) on /usr/src type ffs (rw, local, nodev, nosuid, softdep, ctime=Tue Jun 14 20:32:11 2016)
/dev/sd0e (bd15538f0bff9935.e) on /var type ffs (rw, local, nodev, nosuid, softdep, ctime=Tue Jun 14 20:32:11 2016)
tmpfs on /etc/secrets type tmpfs (rw, local, ctime=Tue Jun 14 20:32:02 2016)
[INFO    ] Executing command 'ls -l /dev/sd0a' in directory '/home/viq'
[DEBUG   ] stdout: brw-r-----  1 root  operator    4,   0 Jun 14 20:32 /dev/sd0a
[INFO    ] Executing command 'ls -l /dev/sd0k' in directory '/home/viq'
[DEBUG   ] stdout: brw-r-----  1 root  operator    4,  10 Jun 14 20:32 /dev/sd0k
[INFO    ] Executing command 'ls -l /dev/sd0d' in directory '/home/viq'
[DEBUG   ] stdout: brw-r-----  1 root  operator    4,   3 Jun 14 20:32 /dev/sd0d
[INFO    ] Executing command 'ls -l /dev/sd0f' in directory '/home/viq'
[DEBUG   ] stdout: brw-r-----  1 root  operator    4,   5 Jun 14 20:32 /dev/sd0f
[INFO    ] Executing command 'ls -l /dev/sd0g' in directory '/home/viq'
[DEBUG   ] stdout: brw-r-----  1 root  operator    4,   6 Jun 14 20:32 /dev/sd0g
[INFO    ] Executing command 'ls -l /dev/sd0h' in directory '/home/viq'
[DEBUG   ] stdout: brw-r-----  1 root  operator    4,   7 Jun 14 20:32 /dev/sd0h
[INFO    ] Executing command 'ls -l /dev/sd0j' in directory '/home/viq'
[DEBUG   ] stdout: brw-r-----  1 root  operator    4,   9 Jun 14 20:32 /dev/sd0j
[INFO    ] Executing command 'ls -l /dev/sd0i' in directory '/home/viq'
[DEBUG   ] stdout: brw-r-----  1 root  operator    4,   8 Jun 14 20:32 /dev/sd0i
[INFO    ] Executing command 'ls -l /dev/sd0e' in directory '/home/viq'
[DEBUG   ] stdout: brw-r-----  1 root  operator    4,   4 Jun 14 20:32 /dev/sd0e
[INFO    ] Executing command 'ls -l tmpfs' in directory '/home/viq'
[ERROR   ] Command 'ls -l tmpfs' failed with return code: 1
[ERROR   ] stderr: ls: tmpfs: No such file or directory
[ERROR   ] retcode: 1
[ERROR   ] An un-handled exception was caught by salt's global exception handler:
IndexError: list index out of range
Traceback (most recent call last):
  File "/usr/local/bin/salt-call", line 11, in <module>
    salt_call()
  File "/usr/local/lib/python2.7/site-packages/salt/scripts.py", line 345, in salt_call
    client.run()
  File "/usr/local/lib/python2.7/site-packages/salt/cli/call.py", line 58, in run
    caller.run()
  File "/usr/local/lib/python2.7/site-packages/salt/cli/caller.py", line 134, in run
    ret = self.call()
  File "/usr/local/lib/python2.7/site-packages/salt/cli/caller.py", line 197, in call
    ret['return'] = func(*args, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/salt/modules/mount.py", line 208, in active
    _active_mounts_openbsd(ret)
  File "/usr/local/lib/python2.7/site-packages/salt/modules/mount.py", line 156, in _active_mounts_openbsd
    'opts': _resolve_user_group_names(parens[1].split(", "))}
IndexError: list index out of range
Traceback (most recent call last):
  File "/usr/local/bin/salt-call", line 11, in <module>
    salt_call()
  File "/usr/local/lib/python2.7/site-packages/salt/scripts.py", line 345, in salt_call
    client.run()
  File "/usr/local/lib/python2.7/site-packages/salt/cli/call.py", line 58, in run
    caller.run()
  File "/usr/local/lib/python2.7/site-packages/salt/cli/caller.py", line 134, in run
    ret = self.call()
  File "/usr/local/lib/python2.7/site-packages/salt/cli/caller.py", line 197, in call
    ret['return'] = func(*args, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/salt/modules/mount.py", line 208, in active
    _active_mounts_openbsd(ret)
  File "/usr/local/lib/python2.7/site-packages/salt/modules/mount.py", line 156, in _active_mounts_openbsd
    'opts': _resolve_user_group_names(parens[1].split(", "))}
IndexError: list index out of range

Versions Report

$ sudo salt-call --versions-report 
Salt Version:
           Salt: 2016.3.0

Dependency Versions:
           cffi: Not Installed
       cherrypy: Not Installed
       dateutil: Not Installed
          gitdb: Not Installed
      gitpython: Not Installed
          ioflo: Not Installed
         Jinja2: 2.7.3
        libgit2: Not Installed
        libnacl: Not Installed
       M2Crypto: 0.24.0
           Mako: Not Installed
   msgpack-pure: Not Installed
 msgpack-python: 0.4.7
   mysql-python: Not Installed
      pycparser: Not Installed
       pycrypto: 2.6.1
         pygit2: Not Installed
         Python: 2.7.11 (default, Jun  8 2016, 15:24:44)
   python-gnupg: 0.3.8
         PyYAML: 3.11
          PyZMQ: 15.2.0
           RAET: Not Installed
          smmap: Not Installed
        timelib: Not Installed
        Tornado: 4.3
            ZMQ: 4.1.4

System Versions:
           dist:   
        machine: amd64
        release: 6.0
         system: OpenBSD
        version: Not Installed

Currently the master is:

salt --versions-report
Salt Version:
           Salt: 2015.8.10

Dependency Versions:
         Jinja2: 2.8
       M2Crypto: 0.24.0
           Mako: 1.0.4
         PyYAML: 3.11
          PyZMQ: 15.2.0
         Python: 2.7.11 (default, Mar 31 2016, 06:18:34)
           RAET: Not Installed
        Tornado: 4.3
            ZMQ: 4.1.4
           cffi: 1.6.0
       cherrypy: Not Installed
       dateutil: Not Installed
          gitdb: 0.6.4
      gitpython: 1.0.1
          ioflo: Not Installed
        libgit2: 0.24.0
        libnacl: Not Installed
   msgpack-pure: Not Installed
 msgpack-python: 0.4.7
   mysql-python: Not Installed
      pycparser: 2.14
       pycrypto: 2.6.1
         pygit2: 0.24.0
   python-gnupg: 0.3.9.dev0
          smmap: 0.9.0
        timelib: Not Installed

System Versions:
           dist:   
        machine: x86_64
        release: 4.5.7.201606080852-2-grsec

but I've demonstrated above this happens as well with --local.

Interestingly enough, it works on

Salt Version:
           Salt: 2015.8.8

Dependency Versions:
         Jinja2: 2.7.3
       M2Crypto: 0.24.0
           Mako: Not Installed
         PyYAML: 3.11
          PyZMQ: 15.2.0
         Python: 2.7.11 (default, May 23 2016, 04:54:03)
           RAET: Not Installed
        Tornado: 4.3
            ZMQ: 4.1.4
           cffi: 1.4.2
       cherrypy: Not Installed
       dateutil: 2.5.2
          gitdb: Not Installed
      gitpython: Not Installed
          ioflo: Not Installed
        libgit2: Not Installed
        libnacl: Not Installed
   msgpack-pure: Not Installed
 msgpack-python: 0.4.7
   mysql-python: Not Installed
      pycparser: 2.10
       pycrypto: 2.6.1
         pygit2: Not Installed
   python-gnupg: 0.3.8
          smmap: Not Installed
        timelib: Not Installed

System Versions:
           dist:   
        machine: amd64
        release: 6.0

The text was updated successfully, but these errors were encountered:

Ch3LL · 2016-06-15T17:54:52Z

@viq I am able to verify this behavior that it is working in 2015.8.10 but broken 2016.3.0.

My git bisect is showing:

7c3f6cf2a733b34e11d0e188e5546fe9ec544c50 is the first bad commit
commit 7c3f6cf2a733b34e11d0e188e5546fe9ec544c50
Author: nfraison <nfraison@yahoo.fr>
Date:   Tue Jun 30 22:14:37 2015 +0200

    Ensure object is type basestring and not only string

:040000 040000 d6e304947d8d6b00041cac6087197976e137d38f 04501c9e412fa3f5bf6e5d4bdd101e9fd510c8e8 M      salt

Which doesn't seem right but I did that git bisect multiple times.

ajacoutot · 2016-06-16T08:52:47Z

I believe this should fix it:
#34057

mount(8) output is a little bit different on OpenBSD between local and special or remote filesystems (e.g. tmpfs or nfs). These do not use a UUID nor a device. #34012

rallytime · 2016-06-16T15:30:24Z

@viq or @Ch3LL can you try the fix in #34057 to confirm that this is fixed? If so, I can back-port that fix from the develop branch to the 2016.3 branch.

viq · 2016-06-16T18:34:42Z

When executing sudo salt-call state.highstate with above config I get every time in output

[INFO    ] Executing command 'mount -u -o rw,-s20M,-uroot,-gwheel,-m0700 -t tmpfs tmpfs /etc/secrets ' in directory '/home/viq'
[ERROR   ] Command 'mount -u -o rw,-s20M,-uroot,-gwheel,-m0700 -t tmpfs tmpfs /etc/secrets ' failed with return code: 1
[ERROR   ] stderr: mount_tmpfs: tmpfs on /etc/secrets: Operation not supported
[ERROR   ] retcode: 1

and result of

local:
----------
          ID: secrets storage
    Function: mount.mounted
        Name: /etc/secrets
      Result: mount_tmpfs: tmpfs on /etc/secrets: Operation not supported
     Comment: Target was already mounted. Entry already exists in the fstab.
     Started: 20:32:54.019572
    Duration: 558.985 ms
     Changes:   
              ----------
              umount:
                  Forced remount because options (-m0700) changed

but it works.

ajacoutot · 2016-06-16T18:50:58Z

That's an unrelated issue. I'll have a look at fixing it on the OpenBSD side.
Thanks.

viq · 2016-06-16T20:30:19Z

Thank you @ajacoutot :)

ajacoutot · 2016-06-18T12:05:24Z

@viq ok so I looked at modifying mount(8) -v output on OpenBSD but there's just too much discrepancy.
In your specific case what you can do is just use hidden_opts.
e.g.
salt-call --local state.single mount.mounted device=tmpfs name=/mnt persist=False fstype=tmpfs opts="rw,-m0700" hidden_opts="-m0700"

viq · 2016-06-18T21:50:43Z

I had to add a bit more to hidden_opts, but with salt as in ports the state listed below works:

secrets storage:
  mount.mounted:
    - name: /etc/secrets
    - device: tmpfs
    - fstype: tmpfs
    - opts: rw,-s20M,-uroot,-gwheel,-m0700
    - dump: 0
    - pass_num: 0
    - persist: True
    - mkmnt: True
    - hidden_opts:
      - "-m0700"
      - "-gwheel"
      - "-uroot"
      - "-s20M"

So now it's just to get this backported to 2016.3.

ajacoutot · 2016-06-18T22:01:36Z

@viq yes, I was just providing an example; if you are using more opts, then you will end up hiding a few more.
I locally changed mount output to provide a more complete output but there's a discrepancy between the command line and the output and fixing it all on each and every mount_* helper would not make sense. Using hidden_opts is perfect for that use case.
So yeah, +1 to backport it to the stable branch.

mount(8) output is a little bit different on OpenBSD between local and special or remote filesystems (e.g. tmpfs or nfs). These do not use a UUID nor a device. saltstack#34012

rallytime · 2016-06-20T14:08:27Z

@viq I have backported this fix to 2016.3 in #34133. Thank you for testing and confirming.

@ajacoutot Thanks again for the fix and for following up on this issue.

Ch3LL added Bug broken, incorrect, or confusing behavior P4 Priority 4 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around State-Module Platform Relates to OS, containers, platform-based utilities like FS, system based apps labels Jun 15, 2016

Ch3LL added this to the Approved milestone Jun 15, 2016

Ch3LL added the Confirmed Salt engineer has confirmed bug/feature - often including a MCVE label Jun 15, 2016

ajacoutot mentioned this issue Jun 16, 2016

_active_mounts_openbsd: unbreak output for special filesystems #34057

Merged

rallytime added the fixed-pls-verify fix is linked, bug author to confirm fix label Jun 16, 2016

rallytime mentioned this issue Jun 20, 2016

Back-port #34057 to 2016.3 #34133

Merged

rallytime closed this as completed Jun 22, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

States mount.* fail on OpenBSD's tmpfs #34012

States mount.* fail on OpenBSD's tmpfs #34012

viq commented Jun 14, 2016

Ch3LL commented Jun 15, 2016

ajacoutot commented Jun 16, 2016

rallytime commented Jun 16, 2016

viq commented Jun 16, 2016

ajacoutot commented Jun 16, 2016

viq commented Jun 16, 2016

ajacoutot commented Jun 18, 2016

viq commented Jun 18, 2016

ajacoutot commented Jun 18, 2016

rallytime commented Jun 20, 2016

States mount.* fail on OpenBSD's tmpfs #34012

States mount.* fail on OpenBSD's tmpfs #34012

Comments

viq commented Jun 14, 2016

States mount.* fail to take into consideration mount output on OpenBSD

Setup

Steps to Reproduce Issue

Versions Report

Ch3LL commented Jun 15, 2016

ajacoutot commented Jun 16, 2016

rallytime commented Jun 16, 2016

viq commented Jun 16, 2016

ajacoutot commented Jun 16, 2016

viq commented Jun 16, 2016

ajacoutot commented Jun 18, 2016

viq commented Jun 18, 2016

ajacoutot commented Jun 18, 2016

rallytime commented Jun 20, 2016

States mount.* fail to take into consideration `mount` output on OpenBSD