zpool state module needs support for disk vdev

[aphor]

salt.modules.zpool does not support explicit (the second simplest example) "disk" type zpool vdev

Since the salt.states.zpool requires a vdev in layout kwarg in state.sls files, it is impossible to use this state module to create a simple single disk vdev zpool.

This should be a valid state

newpool:
  zpool.present:
    - config:
        import: false
        force: true
    - properties:
        comment: salty storage pool
    - layout:
        disk-0:
          /dev/disk0
          /dev/disk1

but produces an ambiguous error, assuming that the "disk" vdev is supposed to be interpreted by the salt.modules.zpool.create() as a device node on the filesystem

             if not os.path.exists(vdev):
                 ret[zpool][vdev] = 'not present on filesystem'

salt.states.zpool also does a similar (broken) check (DRY?) to validate the state layout.

[rallytime]

Thanks @aphor for the suggestion. Sounds good to me.

FYI @sjorge or @nmadhok - you guys might be interested in this feature request.

[sjorge]

@aphor if I understand correctly, you're looking for the equivalent of zpool create tank /dev/disk0 /dev/disk1 using the state module?

I'm pretty sure I tested this with the execution module, I think that should work fine. Not sure I tested that with the state module. (Can't check for another week+, traveling with limited internet)

As for the error, It could be improved yeah. Although I couldn't find a better fitting one.
the lower level vdev can be a file, device node or a character device. Depending on the operating system they can live almost anywhere (with the exception of device nodes of course), perhaps a shorter 'not present' or 'could not locate' would be slightly less confusing.

Edit:
After having a look at the code, it should work fine with the state module also:

newpool:
  zpool.present:
    - config:
        import: false
        force: true
    - properties:
        comment: salty storage pool
    - layout:
        /dev/disk0
        /dev/disk1

[aphor]

@sjorge yes, and I just realized I had botched my example syntax.

BTW: I have a PR on the way.

[aphor]

I think this is more about consistency in the YAML requirements to use the zpool state module.

#34770 <-- not too hairy.

[sjorge]

PR with a small docs update + support for the fake 'disk' vdev is going through my internal testing, will take a bit as I am on holiday on 3G internet.

Alternative PR that only makes small accommodations in the state module is here: #34791
Took a while to boot my slugish test vm to run some tests, but all seems well.

[sjorge]

The fix seems to have made it into both 2016.3 and develop. @aphor is everything working 'as expected' now?

[aphor]

This is also working for me now. Thanks!