Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

salt.state.zpool tweaks #34791

Merged
merged 1 commit into from
Jul 19, 2016
Merged

salt.state.zpool tweaks #34791

merged 1 commit into from
Jul 19, 2016

Conversation

sjorge
Copy link
Contributor

@sjorge sjorge commented Jul 19, 2016

What does this PR do?

  • improve documentation in regards to creating a striped zpool
  • allow the use of the fake vdev type disk

I it is very unlikely that a vdev type with the name disk will ever be added in the underlaying cli tools. For this reason the salt.modules.zpool module does not support the fake vdev type. It seems wise to keep this as close to the actual zpool command as possible.

This vdev type is intentionally not documented, in favor of the correct way of creating such a zpool.

What issues does this PR fix or reference?

#34762

Previous Behavior

n/a

New Behavior

Allow the following states to work:

stripedpoolc:
  zpool.present:
    - config:
        import: false
        force: true
    - properties:
        comment: salty storage pool
    - layout:
        disk-0:
          /tmp/vdisk0
        disk-1:
          /tmp/vdisk1

stripedpoolb:
  zpool.present:
    - config:
        import: false
        force: true
    - properties:
        comment: salty storage pool
    - layout:
        disk-0:
          /tmp/vdisk0
          /tmp/vdisk1

stripedpoola:
  zpool.present:
    - config:
        import: false
        force: true
    - properties:
        comment: salty storage pool
    - layout:
          - /tmp/vdisk0
          - /tmp/vdisk1

Tests written?

No

…later if a disk vdev ever gets added to the cli tools. improve documentation explaining how to create a striped pool without the "fake" vdev type
@cachedout cachedout merged commit 49ab3fd into saltstack:2016.3 Jul 19, 2016
@sjorge sjorge deleted the zpool-state-tweaks branch July 20, 2016 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants