Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeprecationWarning: The "osmajorrelease" will be a type of an integer. #35972

Closed
tjyang opened this issue Aug 31, 2016 · 8 comments
Closed

DeprecationWarning: The "osmajorrelease" will be a type of an integer. #35972

tjyang opened this issue Aug 31, 2016 · 8 comments
Assignees
Labels
Bug broken, incorrect, or confusing behavior Core relates to code central or existential to Salt fixed-pls-verify fix is linked, bug author to confirm fix Grains P1 Priority 1 severity-critical top severity, seen by most users, serious issues severity-low 4th level, cosemtic problems, work around exists ZRELEASED - Carbon ZRELEASED - 2016.3.4
Milestone

Comments

@tjyang
Copy link
Contributor

tjyang commented Aug 31, 2016

Description of Issue/Question

I am seeing this warning message after 6.3.2 to 6.3.3 upgrade

Setup

salt-run -t 60 manage.down

Steps to Reproduce Issue

[root@salt01 ~]# salt-run -t 60 manage.down
[WARNING ] /usr/lib/python2.7/site-packages/salt/grains/core.py:1493: DeprecationWarning: The "osmajorrelease" will be a type of an integer.

Versions Report

Salt Version:
Salt: 2016.3.3

Dependency Versions:
cffi: 0.8.6
cherrypy: 3.2.2
dateutil: 1.5
gitdb: 0.6.4
gitpython: 1.0.1
ioflo: 1.3.8
Jinja2: 2.8
libgit2: 0.21.0
libnacl: 1.4.3
M2Crypto: 0.21.1
Mako: 0.8.1
msgpack-pure: Not Installed
msgpack-python: 0.4.7
mysql-python: 1.2.3
pycparser: 2.14
pycrypto: 2.6.1
pygit2: 0.21.4
Python: 2.7.5 (default, Nov 20 2015, 02:00:19)
python-gnupg: 0.3.8
PyYAML: 3.11
PyZMQ: 15.3.0
RAET: Not Installed
smmap: 0.9.0
timelib: 0.2.4
Tornado: 4.2.1
ZMQ: 4.1.4

System Versions:
dist: centos 7.2.1511 Core
machine: x86_64
release: 3.10.0-327.28.2.el7.x86_64
system: Linux
version: CentOS Linux 7.2.1511 Core

@ndobbs
Copy link

ndobbs commented Sep 1, 2016

+1 I'm running into this, too. I am filtering on the grain 'osmajorrelease' in several of my states but do not see that being the issue here. My minion and saltmaster are running the same versions.

Salt Version:
           Salt: 2016.3.3

Dependency Versions:
           cffi: Not Installed
       cherrypy: Not Installed
       dateutil: 1.5
          gitdb: Not Installed
      gitpython: Not Installed
          ioflo: Not Installed
         Jinja2: 2.7.2
        libgit2: Not Installed
        libnacl: Not Installed
       M2Crypto: Not Installed
           Mako: 0.9.1
   msgpack-pure: Not Installed
 msgpack-python: 0.4.6
   mysql-python: 1.2.3
      pycparser: Not Installed
       pycrypto: 2.6.1
         pygit2: Not Installed
         Python: 2.7.6 (default, Jun 22 2015, 17:58:13)
   python-gnupg: Not Installed
         PyYAML: 3.10
          PyZMQ: 14.0.1
           RAET: Not Installed
          smmap: Not Installed
        timelib: Not Installed
        Tornado: 4.2.1
            ZMQ: 4.0.5

System Versions:
           dist: Ubuntu 14.04 trusty
        machine: x86_64
        release: 3.19.0-59-generic
         system: Linux
        version: Ubuntu 14.04 trusty

@Sakorah
Copy link

Sakorah commented Sep 1, 2016

Hi,

I'm seeing this messages as well. I certainly do not use this grain in my environment and still get this message. Is this "works as designed" then?

@kkoppel
Copy link

kkoppel commented Sep 2, 2016

Same here. I believe version 2016.3.3 always shows this warning whenever the grains data is compiled.

The warning already got removed in 45a12cc. Would be really great if this could be back-ported to 2016.3.

@Ch3LL
Copy link
Contributor

Ch3LL commented Sep 2, 2016

Looks like we need to remove this warning in 2016 as well since it will be included in the release notes for nitrogen. Thanks for the heads up guys.

@Ch3LL Ch3LL added Bug broken, incorrect, or confusing behavior severity-low 4th level, cosemtic problems, work around exists Core relates to code central or existential to Salt P1 Priority 1 Grains labels Sep 2, 2016
@Ch3LL Ch3LL added this to the Approved milestone Sep 2, 2016
@Ch3LL Ch3LL added severity-critical top severity, seen by most users, serious issues ZRELEASED - Carbon ZRELEASED - 2016.3.4 labels Sep 2, 2016
rallytime pushed a commit to rallytime/salt that referenced this issue Sep 6, 2016
@rallytime
Copy link
Contributor

Thanks @tjyang for filing this and to @kkoppel for pointing to the fix in develop. I've submitted #36068 to fix this.

@rallytime rallytime added the fixed-pls-verify fix is linked, bug author to confirm fix label Sep 6, 2016
@rallytime rallytime modified the milestones: C 4, Approved Sep 6, 2016
@rallytime rallytime self-assigned this Sep 6, 2016
@willneumob
Copy link

+1 for realeasing under 2016.3.

@cachedout
Copy link
Contributor

It will be in the next release of 2016.3. Thanks all.

@tjyang
Copy link
Contributor Author

tjyang commented Sep 9, 2016

Thanks for the quick remedy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Core relates to code central or existential to Salt fixed-pls-verify fix is linked, bug author to confirm fix Grains P1 Priority 1 severity-critical top severity, seen by most users, serious issues severity-low 4th level, cosemtic problems, work around exists ZRELEASED - Carbon ZRELEASED - 2016.3.4
Projects
None yet
Development

No branches or pull requests

8 participants