Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pillar/libvirt.py assume certtool is available and works everytime #36788

Closed
damon-atkins opened this issue Oct 5, 2016 · 3 comments
Closed
Labels
Bug broken, incorrect, or confusing behavior P4 Priority 4 Pillar Platform Relates to OS, containers, platform-based utilities like FS, system based apps severity-low 4th level, cosemtic problems, work around exists stale
Milestone

Comments

@damon-atkins
Copy link
Contributor

Description of Issue/Question

salt/pillar/libvirt.py Calls the program certtool several times. However it seems not to check the results or even check if certtool installed. Result in the state which uses this failing without the user understanding why.

Setup

Salt Develop or Prev versions.

Steps to Reproduce Issue

see https://docs.saltstack.com/en/latest/topics/tutorials/cloud_controller.html example

@damon-atkins damon-atkins changed the title salt/pillar/libvirt.py assume certtool is available and works everytime pillar/libvirt.py assume certtool is available and works everytime Oct 5, 2016
@gtmanfred gtmanfred added the Bug broken, incorrect, or confusing behavior label Oct 5, 2016
@gtmanfred gtmanfred added this to the Approved milestone Oct 5, 2016
@gtmanfred gtmanfred added severity-low 4th level, cosemtic problems, work around exists P4 Priority 4 labels Oct 5, 2016
@gtmanfred gtmanfred added Platform Relates to OS, containers, platform-based utilities like FS, system based apps Pillar TEAM Platform labels Oct 5, 2016
@gtmanfred
Copy link
Contributor

Thanks for reporting this, I have created the above pr to address this issue in 2016.3 and forward

@stale
Copy link

stale bot commented Jul 7, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Jul 7, 2018
@gtmanfred
Copy link
Contributor

This is already fixed in #36803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior P4 Priority 4 Pillar Platform Relates to OS, containers, platform-based utilities like FS, system based apps severity-low 4th level, cosemtic problems, work around exists stale
Projects
None yet
Development

No branches or pull requests

2 participants