Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated platform.linux_distribution() and platform.dist() #37070

Closed
damon-atkins opened this issue Oct 18, 2016 · 3 comments · Fixed by #40009
Closed

Deprecated platform.linux_distribution() and platform.dist() #37070

damon-atkins opened this issue Oct 18, 2016 · 3 comments · Fixed by #40009
Assignees
Labels
Bug broken, incorrect, or confusing behavior Core relates to code central or existential to Salt P4 Priority 4 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around ZRELEASED - 2017.7.0rc1
Milestone

Comments

@damon-atkins
Copy link
Contributor

Description of Issue/Question

http://bugs.python.org/issue1322 platform.linux_distribution() and platform.dist() is being deprecated. The recommendation is to use https://pypi.python.org/pypi/distro instead of platform.linux_distribution() and platform.dist() (https://github.com/nir0s/distro)

It's being removed as it updates far to often to be within the core python code due to changes made in Linux distributions.

Python Versions

Python 2.6 onwards platform.dist() has marked as deprecated
Python 3.7 onwards will no longer have platform.linux_distribution() and platform.dist()

Code within Salt

./grains/core.py:# /etc/DISTRO-release checking that is part of platform.linux_distribution()
./grains/core.py:             platform.linux_distribution(supported_dists=_supported_dists)]
./grains/core.py:        # so that platform.linux_distribution() does the /etc/lsb-release
./version.py:        lin_ver = platform.linux_distribution()
./version.py:        ('dist', ' '.join(platform.dist())),
@Ch3LL
Copy link
Contributor

Ch3LL commented Oct 18, 2016

@damon-atkins thanks for the heads up on this. Looks like we need to get this fixed up especially before we move entirely to python 3 :)

@Ch3LL Ch3LL added Bug broken, incorrect, or confusing behavior Core relates to code central or existential to Salt P4 Priority 4 ZRELEASED - 2017.7.0rc1 labels Oct 18, 2016
@Ch3LL Ch3LL added this to the Approved milestone Oct 18, 2016
@Ch3LL Ch3LL added the severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around label Oct 18, 2016
@gtmanfred gtmanfred self-assigned this Mar 9, 2017
@gtmanfred gtmanfred modified the milestones: Nitrogen 5, Approved Mar 10, 2017
@Ch3LL Ch3LL added the branch label Mar 13, 2017
@cachedout
Copy link
Contributor

ETA, EOD March 14th.

@damon-atkins
Copy link
Contributor Author

Thanks

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Core relates to code central or existential to Salt P4 Priority 4 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around ZRELEASED - 2017.7.0rc1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants