Add run-time params to SSHClient and CloudClient for common operations

[sumeetisp]

Description of Issue/Question

I am using the following format for salt-ssh rest call,
{
"ssh_passwd": "Spam99",
"fun": "test.ping",
"tgt": "cri-ssh",
"eauth": "pam",
"client": "ssh",
"timeout": 2000,
"username": "admin",
"password": "admin",
"ssh_passwd": "some_password",
"ssh_key_deploy": "true"
}

My expectation is that this will login into the target, run the test.ping, deploy the salt-ssh key and get me the result.
I get the result as true but the key doesnt get deployed.
The same when i run via salt master gets the key deployed.

[gtmanfred]

Can you please provide the --versions-report of the salt-ssh command like the issue template requested so that I can better replicate your issue on the same versions?

Thanks,
Daniel

[sumeetisp]

Salt Version:
Salt: 2016.11.2

Dependency Versions:
cffi: 1.9.1
cherrypy: 3.2.2
dateutil: 2.6.0
gitdb: 0.5.4
gitpython: 0.3.2 RC1
ioflo: Not Installed
Jinja2: 2.8
libgit2: Not Installed
libnacl: Not Installed
M2Crypto: 0.21.1
Mako: 0.9.1
msgpack-pure: Not Installed
msgpack-python: 0.4.6
mysql-python: 1.2.3
pycparser: 2.10
pycrypto: 2.6.1
pygit2: Not Installed
Python: 2.7.6 (default, Oct 26 2016, 20:30:19)
python-gnupg: Not Installed
PyYAML: 3.10
PyZMQ: 14.0.1
RAET: Not Installed
smmap: 0.8.2
timelib: Not Installed
Tornado: 4.2.1
ZMQ: 4.0.4

System Versions:
dist: Ubuntu 14.04 trusty
machine: x86_64
release: 3.16.0-30-generic
system: Linux
version: Ubuntu 14.04 trusty

[sumeetisp]

@gtmanfred Did it work for you?

[gtmanfred]

I have been at a conference the last two days, I am working through the issue queue, then I am going to test this.

[gtmanfred]

I believe that this is a limitation of the api, that it does not update the opts for salt-ssh commands.

@whiteinge can you verify this?

Thanks,
Daniel

[whiteinge]

Pretty sure you're right. I believe that both SSHClient and CloudClient look for some run-time params in __opts__. To match the other client interfaces in Salt, __opts__ should be pretty static data and any params that are likely to change between one invocation and the next should come from *Client.cmd(..., **kwargs).

[gtmanfred]

Thanks, I am going to mark this as a bug.

Daniel

[whiteinge]

Cool, thanks. I removed the salt-api label since no changes are required there but I'd like to be involved when someone picks this up to make sure it matches the other clients.

[sumeetisp]

In that case ,can i use the Saltfile mentioned here . The documention doesnt mention the location of these configuration parameters. I tried keeping it in /etc/salt/master but it did not work. And if its not master config then what is the location of this file? Is Saltfile a generaal term being used here or name of the file itself?

[gtmanfred]

Saltfile won't work here, it is specifically for use with the cli functions.

…

On Thu, May 18, 2017 at 9:39 PM sumeetisp ***@***.***> wrote: In that case can i use the Saltfile mentioned here <https://docs.saltstack.com/en/latest/topics/ssh/#define-cli-options-with-saltfile>. THe documention doesnt mention the location of these configuration parameters. I tried keeping it in /etc/salt/master but it did not work. And if its not master config then what is the location of this file? Is Saltfile a generaal term being used here or name of the file itself? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#41237 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAssoYHevdOidqv-qASmdnMvKTuOk-iWks5r7Q7XgaJpZM4Na543> .

[sumeetisp]

cli option present here are the cli options? If yes this includes --key-deploy. Where does this Saltfile reside?

[gtmanfred]

It goes in the directory you are running the salt-ssh command from https://docs.saltstack.com/en/latest/topics/ssh/#define-cli-options-with-saltfile It is mostly meant to make it so that you don't have to provide cli arguments to run salt-ssh out of a git repository

…

On Fri, May 19, 2017 at 4:54 AM sumeetisp ***@***.***> wrote: cli option present here <https://docs.saltstack.com/en/latest/ref/cli/salt-ssh.html> are the cli option? If yes this includes --key-deploy. Where does this Saltfile reside? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#41237 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAssoS8cG6J5j2Dtsmqfd_xWBrgLiKfZks5r7XTfgaJpZM4Na543> .

[whiteinge]

Edited the title and linked an older related issue.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.