Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request - salt.modules.win_useradd / salt.states.user should accept SID's for usernames and groups on Windows #41368

Closed
lubyou opened this issue May 21, 2017 · 2 comments
Labels
Execution-Module Feature new functionality including changes to functionality and code refactors, etc. Platform Relates to OS, containers, platform-based utilities like FS, system based apps stale Windows
Milestone

Comments

@lubyou
Copy link
Contributor

lubyou commented May 21, 2017

Hi,

It would be very nice if one would be able to use SID's for the various parameters that expect security principals.

Names and groups are localised on Windows, it is usually easier to refer to well known SID's, instead of trying to cover all the possible group or user names.

Example:

Try to add a new user and put him into the administrators group (S-1-5-32-544) on a French Windows 7:

C:\salt>salt-call user.add name=francis groups=S-1-5-32-544
[ERROR   ] Command 'net localgroup "S-1-5-32-544" francis /add' failed with return code: 2
[ERROR   ] stderr: L'erreur système 1376 s'est produite.

Le groupe local spécifié n'existe pas.
[ERROR   ] retcode: 2
[ERROR   ]
local:
    False

Works fine if one uses the group name:

C:\salt>salt-call user.add name=francis groups=administrateurs
local:
    True
@Ch3LL
Copy link
Contributor

Ch3LL commented May 22, 2017

Sounds like a good idea. Will approve as a feature request. Thanks

@Ch3LL Ch3LL added Execution-Module Feature new functionality including changes to functionality and code refactors, etc. Platform Relates to OS, containers, platform-based utilities like FS, system based apps Windows labels May 22, 2017
@Ch3LL Ch3LL added this to the Approved milestone May 22, 2017
@stale
Copy link

stale bot commented Oct 24, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Oct 24, 2018
@stale stale bot closed this as completed Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Execution-Module Feature new functionality including changes to functionality and code refactors, etc. Platform Relates to OS, containers, platform-based utilities like FS, system based apps stale Windows
Projects
None yet
Development

No branches or pull requests

2 participants