PyCrypto is always being downloaded and installed

[tsaridas]

Description of Issue/Question

salt/setup.py

Line 376 in 68c84a2

class InstallPyCryptoWindowsWheel(Command):

shows the package is being downloaded and installed every time.

I suggest there is a lookup first to see if its installed and version matches and then perform the steps.

        import pip
        package_name = 'pycrypto'
        package_version = '2.6.1'
        local_packages = pip.get_installed_distributions(local_only=True)
        for package in local_packages:
            if str(package).startswith(package_name) and str(package).endswith(package_version):
                return

        platform_bits, _ = platform.architecture()
        call_arguments = ['pip', 'install', 'wheel']
        if platform_bits == '64bit':
            call_arguments.append(
                'https://repo.saltstack.com/windows/dependencies/64/{0}-{1}-cp27-none-win_amd64.whl'
                ''.format(package_name, package_version)
            )
        else:
            call_arguments.append(
                'https://repo.saltstack.com/windows/dependencies/32/{0}-{1}-cp27-none-win32.whl'
                ''.format(package_name, package_version)
            )
        with indent_log():
            call_subprocess(call_arguments)

Versions Report

latest

[Ch3LL]

@s0undt3ch looks like you add this class in the setup file. Any problems with adding this logic to check if its already installed first?

[s0undt3ch]

No issues with first checking if it's installed.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.