Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

salt-ssh -L with hosts down or unreachable returns wrong results #43449

Closed
ecgg opened this issue Sep 12, 2017 · 2 comments
Closed

salt-ssh -L with hosts down or unreachable returns wrong results #43449

ecgg opened this issue Sep 12, 2017 · 2 comments
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix P2 Priority 2 Salt-SSH severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Milestone

Comments

@ecgg
Copy link

ecgg commented Sep 12, 2017

Description of Issue/Question

When a host is down or doesn't resolve salt-ssh -L returns results for the last host which worked.

Setup

# etc/roster
goodboy:
    host:   goodboy.example.com

downboy:
    host: downboy.example.com

noresolve:
    host:   doesntresolveatall.example.com

Steps to Reproduce Issue

salt-ssh -L goodboy,downboy,noresolve -r 'uname'

noresolve:
    ----------
    retcode:
        0
    stderr:
        Connection to goodboy closed.
    stdout:
        Linux goodboy 2.6.32-696.6.3.el6.x86_64 #1 SMP Fri Jun 30 13:24:18 EDT 2017 x86_64 x86_64 x86_64 GNU/Linux
downboy:
    ----------
    retcode:
        0
    stderr:
        Connection to goodboy closed.
    stdout:
        Linux goodboy 2.6.32-696.6.3.el6.x86_64 #1 SMP Fri Jun 30 13:24:18 EDT 2017 x86_64 x86_64 x86_64 GNU/Linux
goodboy:
    ----------
    retcode:
        0
    stderr:
        Connection to goodboy closed.
    stdout:
        Linux goodboy 2.6.32-696.6.3.el6.x86_64 #1 SMP Fri Jun 30 13:24:18 EDT 2017 x86_64 x86_64 x86_64 GNU/Linux

Versions Report

Salt Version:
Salt: 2017.7.0

Dependency Versions:
cffi: 1.10.0
cherrypy: Not Installed
dateutil: 2.6.1
docker-py: Not Installed
gitdb: Not Installed
gitpython: Not Installed
ioflo: Not Installed
Jinja2: 2.9.6
libgit2: Not Installed
libnacl: Not Installed
M2Crypto: Not Installed
Mako: Not Installed
msgpack-pure: Not Installed
msgpack-python: 0.4.8
mysql-python: Not Installed
pycparser: 2.18
pycrypto: 2.6.1
pycryptodome: Not Installed
pygit2: Not Installed
Python: 2.7.13 (default, Jun 26 2017, 10:20:05)
python-gnupg: Not Installed
PyYAML: 3.12
PyZMQ: 16.0.2
RAET: Not Installed
smmap: Not Installed
timelib: Not Installed
Tornado: 4.5.1
ZMQ: 4.1.6

System Versions:
dist: fedora 26 Twenty Six
locale: UTF-8
machine: x86_64
release: 4.12.9-300.fc26.x86_64
system: Linux
version: Fedora 26 Twenty Six

@garethgreenaway garethgreenaway added this to the Approved milestone Sep 12, 2017
@garethgreenaway garethgreenaway added Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around P2 Priority 2 Salt-SSH labels Sep 12, 2017
@garethgreenaway
Copy link
Contributor

Thanks for the report. We'll get someone to look into this asap.

@rallytime
Copy link
Contributor

@ecgg This should be fixed with #43889. Can you give that a try?

@rallytime rallytime added the fixed-pls-verify fix is linked, bug author to confirm fix label Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix P2 Priority 2 Salt-SSH severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Projects
None yet
Development

No branches or pull requests

3 participants