Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gce cloud provider breaks for make_master: True #43997

Closed
unthought opened this issue Oct 10, 2017 · 1 comment
Closed

gce cloud provider breaks for make_master: True #43997

unthought opened this issue Oct 10, 2017 · 1 comment
Labels
Bug broken, incorrect, or confusing behavior
Milestone

Comments

@unthought
Copy link
Contributor

Description of Issue/Question

GCE provider fails with Host for new master dev-saltmaster was not found, aborting.

Problem seems to be that the returned dict from create() isn't the what bootstrap-salt returns.

Setup

/etc/salt/cloud.profiles.d/dev-profiles.conf

base-dev:
  provider: gce

  # https://docs.saltstack.com/en/latest/topics/cloud/gce.html#ssh-remote-access
  # https://cloud.google.com/compute/docs/instances/adding-removing-ssh-keys#sshkeyformat
  ssh_username: salt-cloud
  ssh_keyfile: /etc/salt/pki/cloud/gce_ssh_keyfile
  metadata: '{"sshKeys": "salt-cloud:ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQCg6UQw0k+kNy3zCV1Y8PQkxIy2IoUxBRjJ5HzQYxB7gorrX2/07dVhNWIfElBI6c4z+u0FSzawEyTDrrZv09rmDZ1e/A7PJR495DKXs5n/sKCOtivdKtBVSBUUYgpqCazUcTGixwTUMVwCN+kpOppZRghRN+91ldmfB9t+3P0PnfDri84+7EygvAaMmTRmWRiTePWCgpGqBpJWP/ewNj5W7E5rbITf5NE9UGlo4DySASiXAC7ipjxRjxqhfbHrW/9+Xs39mo+xSaq/JzOXG7nwWH8NhqlJwSlPvrjn4X5O0CTnJ8yP7t7kV8HonIKaFR3mCVS4ceIGqWsC+l0IT/3N salt-cloud"}'

  image: centos-7
  size: n1-standard-1
  location: southamerica-east1-a
  network: default
  subnetwork: default
  use_persistent_disk: True
  delete_boot_pd: False
  deploy: True
  make_master: False
  ssh_interface: public_ips
  external_ip: "ephemeral"

dev-saltmaster:
  extends: base-dev
  minion:
    grains:
      role: saltmaster
      env: dev
...

/etc/salt/cloud.maps.d/dev-environment.map

dev-saltmaster:
  - dev-saltmaster:
      make_master: True
...

Steps to Reproduce Issue

sudo salt-cloud -l all -m /etc/salt/cloud.maps.d/dev-environment.map

Versions Report

installation running salt-cloud:

Salt Version:
           Salt: 2017.7.2

Dependency Versions:
           cffi: Not Installed
       cherrypy: Not Installed
       dateutil: 2.4.2
      docker-py: Not Installed
          gitdb: 0.6.4
      gitpython: 1.0.1
          ioflo: Not Installed
         Jinja2: 2.8
        libgit2: Not Installed
        libnacl: Not Installed
       M2Crypto: Not Installed
           Mako: 1.0.3
   msgpack-pure: Not Installed
 msgpack-python: 0.4.6
   mysql-python: Not Installed
      pycparser: Not Installed
       pycrypto: 2.6.1
   pycryptodome: Not Installed
         pygit2: Not Installed
         Python: 2.7.12 (default, Nov 19 2016, 06:48:10)
   python-gnupg: Not Installed
         PyYAML: 3.11
          PyZMQ: 15.2.0
           RAET: Not Installed
          smmap: 0.9.0
        timelib: Not Installed
        Tornado: 4.2.1
            ZMQ: 4.1.4

System Versions:
           dist: Ubuntu 16.04 xenial
         locale: UTF-8
        machine: x86_64
        release: 4.4.0-92-generic
         system: Linux
        version: Ubuntu 16.04 xenial

newly provisioned master:

Salt Version:
           Salt: 2017.7.2

Dependency Versions:
           cffi: Not Installed
       cherrypy: Not Installed
       dateutil: Not Installed
      docker-py: Not Installed
          gitdb: Not Installed
      gitpython: Not Installed
          ioflo: Not Installed
         Jinja2: 2.7.2
        libgit2: Not Installed
        libnacl: Not Installed
       M2Crypto: Not Installed
           Mako: Not Installed
   msgpack-pure: Not Installed
 msgpack-python: 0.4.8
   mysql-python: Not Installed
      pycparser: Not Installed
       pycrypto: 2.6.1
   pycryptodome: Not Installed
         pygit2: Not Installed
         Python: 2.7.5 (default, Aug  4 2017, 00:39:18)
   python-gnupg: Not Installed
         PyYAML: 3.11
          PyZMQ: 15.3.0
           RAET: Not Installed
          smmap: Not Installed
        timelib: Not Installed
        Tornado: 4.2.1
            ZMQ: 4.1.4

System Versions:
           dist: centos 7.4.1708 Core
         locale: UTF-8
        machine: x86_64
        release: 3.10.0-693.2.2.el7.x86_64
         system: Linux
        version: CentOS Linux 7.4.1708 Core
@gtmanfred
Copy link
Contributor

Thanks for the PR to fix this!
Daniel

@gtmanfred gtmanfred added the Bug broken, incorrect, or confusing behavior label Oct 10, 2017
@gtmanfred gtmanfred added this to the Approved milestone Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior
Projects
None yet
Development

No branches or pull requests

2 participants