Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change hostname to identifier #48

Closed
thatch45 opened this issue Apr 11, 2011 · 2 comments
Closed

Change hostname to identifier #48

thatch45 opened this issue Apr 11, 2011 · 2 comments
Milestone
0.8.0

Comments

@thatch45
Copy link
Contributor

The salt minion config should have an id, not a hostname
@thatch45
Copy link
Contributor Author

Changed in the code, needs testing

@thatch45
Copy link
Contributor Author

This changes the line protocol, so salt 0.7.0 will not work with 0.8.0
it also slightly shortens the packages, and the config var is better!

arthurzenika pushed a commit to arthurzenika/salt that referenced this issue Sep 17, 2013
@techhat
Merge pull request saltstack#48 from techhat/develop
b616813 
Show helpful error when a bad aws location is used
s0undt3ch added a commit to s0undt3ch/salt that referenced this issue May 10, 2014
@s0undt3ch
Update 'doc/.tx/config' - Build saltstack#48
ea00232 
  http://cookingwithsalt.org/job/salt/job/transifex/48/

Signed-off-by: Pedro Algarvio <pedro@algarvio.me>
s0undt3ch added a commit that referenced this issue May 10, 2014
@s0undt3ch
Merge pull request #12668 from s0undt3ch/hotfix/transifex-updates
532bc7f 
Update 'doc/.tx/config' - Build #48
@dmurphy18 dmurphy18 mentioned this issue Mar 10, 2016
Closed
meaksh pushed a commit to meaksh/salt that referenced this issue Jan 16, 2018
@cavalheiro @brejoc
Removes Beacon configuration Deprecation Warning (saltstack#48)
155276e 
The message "DeprecationWarning: Beacon configuration should be a list
instead of a dictionary." was shown on the console if any beacon was defined
not using lists.

This was incompatible with beacon cfg loaders, namely inotify, that was not yet
upgraded to support this change, causing an error whenever a list definition was
used:

File "/usr/lib/python2.7/site-packages/salt/beacons/inotify.py", line 247
TypeError: list indices must be integers, not dict.,
On same file we can read the comment:
"Configuration for inotify beacon should be a dict of dicts"

This commit removes the deprecation message as per @isbm suggestion.
isbm pushed a commit to isbm/salt that referenced this issue Dec 4, 2018
@cavalheiro @meaksh
Removes Beacon configuration Deprecation Warning (saltstack#48)
d6e4367 
The message "DeprecationWarning: Beacon configuration should be a list
instead of a dictionary." was shown on the console if any beacon was defined
not using lists.

This was incompatible with beacon cfg loaders, namely inotify, that was not yet
upgraded to support this change, causing an error whenever a list definition was
used:

File "/usr/lib/python2.7/site-packages/salt/beacons/inotify.py", line 247
TypeError: list indices must be integers, not dict.,
On same file we can read the comment:
"Configuration for inotify beacon should be a dict of dicts"

This commit removes the deprecation message as per @isbm suggestion.
sbrennan4 pushed a commit to sbrennan4/salt that referenced this issue Sep 17, 2019
@mattp-
Merge pull request saltstack#48 from mphillips81/v2018.3.3-ca
2775702 
salt.runner: don't rely on grains from opts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
1 participant
@thatch45