-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exception using smartos.vm_present to create docker zone #51351
Comments
ping @sjorge can you take a look here? |
I tried a stripped down version (without a nic and onle /config)
Worked fine... what version is the smartos node running? I'm on recent bits, so it might be an older PI. The output of The interesting one is the output of imgadm get
|
Potentially there might be an image without a 'name' tag in the 'manifest' tag... you can check that with |
Thanks for taking a look.
runnning
I tracked this down to a collection of images on a separate zpool. When I exported that zpool, the exception disappeared.
Also, I can't see how to include a couple of environment variables into the docker container. |
Sorry, closed it be mistake |
Can you do an ‘imgadm get’ for the downloaded Plex docker image? Interesting case with the mission names though, I'll see if I can at least make the state ignore those. |
I have some small patches that should at least make it not throw exceptions
If you still have access to the pool with the nameless uuid, please apply the patch and run I'm not 100% sure, but I think this will also fix the issue you are now experiencing. It should default to kernel_version 4.3.0 if it is not specified for docker. But it might have been unhappy before if the image manifest was missing a few items. |
@Ch3LL this patch should probably go in regardless, but I'd like some confirmation to make sure it does not make things worse with image that are incomplete. |
Doing an
I've omitted a load of other images, including several docker images for zones I've created manually. I notice that for all docker images, there is a maximum of one zone created: unlike with base-64-lts etc. Does this imply that creating a new docker vm (even if unsuccessful) results in a new image being downloaded? Is this because of the translation from the docker reference to a new smartos image UUID?
More to come. |
Adding this patch deals with the Exception, even with the temporary pool imported. However, the state still fails with the same error messages. |
I've already opened a PR to get that patch in, ... I'm still looking over the other provided data. |
For me when I import
So I don't think you have multiple instances of the same docker image, currently there is a proble where you cannot update those. So grabbing a newer release is basically delete all the vms + images and import it again.
Using the imgadm.list call in salt filters out those dummy docker-layers, it's basically the result of Can you do a
Should return the same image as |
This absolute minimal state is working for me, just to eliminate a lot of other things it could be unhappy with. It has auto filled in kernel_version as I would expect after double checking the code.
|
THis will end up in 2019.3.1, it won't make it into the initial release |
Sorry, I didn’t get any notifications for these comments until the final one was posted. Not sure why. |
Description of Issue/Question
Getting an exception when trying to create docker version on plexmediaserver on smartos server.
Setup
(Please provide relevant configs and/or SLS files (Be sure to remove sensitive info).)
smartos_docker_containers/plex3.sls
smartos_docker_container/init.sls
Steps to Reproduce Issue
(Include debug logs if possible and relevant.)
Versions Report
(Provided by running
salt --versions-report
. Please also mention any differences in master/minion versions.)Minion
The text was updated successfully, but these errors were encountered: