Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests/unit/utils/test_jinja.py #54265

Closed
dwoz opened this issue Aug 20, 2019 · 1 comment
Closed

Fix tests/unit/utils/test_jinja.py #54265

dwoz opened this issue Aug 20, 2019 · 1 comment
Assignees
Milestone

Comments

@dwoz
Copy link
Contributor

dwoz commented Aug 20, 2019

Description of Issue

The tests in tests/unit/utils/test_jinja.py rely on a file_buffer_size option getting set. They have issues if we run unit tests by themselves. We need to track down where the file_buffer_size option gets set when the tests are run with the full test suite. Then refactor the tests so they don't rely on any other tests.

Setup

Remove the file_buffer_size option which was added in #54264. Run the tests by themselves and with the full test suite.

@stale
Copy link

stale bot commented Jan 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants