Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python package distro should not be imported on Windows #55023

Closed
marbx opened this issue Oct 16, 2019 · 4 comments
Closed

Python package distro should not be imported on Windows #55023

marbx opened this issue Oct 16, 2019 · 4 comments
Assignees
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix P4 Priority 4 Windows
Milestone

Comments

@marbx
Copy link
Contributor

marbx commented Oct 16, 2019

Description of Issue

salt/version py imports distro

distro does not support Windows

Running salt/version.py on Windows results in

ImportError: No module named 'distro'

Current Workaround is to install distro on Windows.

@xeacott xeacott self-assigned this Oct 16, 2019
@xeacott xeacott added Bug broken, incorrect, or confusing behavior P4 Priority 4 Windows labels Oct 16, 2019
@xeacott
Copy link
Contributor

xeacott commented Oct 16, 2019

I have this in a WIP PR, just thinking about what test needs to be added to address behavior.

@xeacott
Copy link
Contributor

xeacott commented Oct 16, 2019

#54953

@marbx
Copy link
Contributor Author

marbx commented Oct 16, 2019 via email

@garethgreenaway garethgreenaway added this to the Approved milestone Oct 16, 2019
@garethgreenaway garethgreenaway added the fixed-pls-verify fix is linked, bug author to confirm fix label Oct 16, 2019
@marbx
Copy link
Contributor Author

marbx commented Nov 1, 2019

See the PR

@marbx marbx closed this as completed Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix P4 Priority 4 Windows
Projects
None yet
Development

No branches or pull requests

3 participants