Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returners getting passed bad information #5518

Closed
WillPlatnick opened this issue Jun 13, 2013 · 4 comments
Closed

Returners getting passed bad information #5518

WillPlatnick opened this issue Jun 13, 2013 · 4 comments
Labels
Bug broken, incorrect, or confusing behavior severity-low 4th level, cosemtic problems, work around exists
Milestone

Comments

@WillPlatnick
Copy link
Contributor

Version: Salt 0.15.3

Returners are getting bad values passed into them. For instance:

sudo salt-call cmd.run ljljlkj --return local

is getting a return code of 0, whereas it should be 127

{'fun': 'cmd.run', 'jid': '20130613112446979126', 'return': '/bin/bash: ljljlkj: command not found', 'retcode': 0, 'id': 'open5.mydomain.com'}

@basepi
Copy link
Contributor

basepi commented Jun 13, 2013

Thanks for the report! We'll look into it.

@UtahDave
Copy link
Contributor

I verified bug as well. Somehow the ret dictionary that's passed in to the returner always has a retcode of 0

thatch45 added a commit that referenced this issue Jul 27, 2013
Populate __context__ with retcode; Fixes issue #5518
@naiyt
Copy link
Contributor

naiyt commented Jul 28, 2013

@thatch45 or @basepi - would one of you be able to close this? That commit fixed the issue.

@UtahDave
Copy link
Contributor

thanks, @naiyt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior severity-low 4th level, cosemtic problems, work around exists
Projects
None yet
Development

No branches or pull requests

4 participants