HTTP authentication support in the cp module

[jlisee]

I am trying to retrieve a file that is behind a web server with basic HTTP auth setup, if I run something like this:

salt-call --local cp.get_url https://username:password@ppa.mydomain.com:443/remote.key /tmp/local_file

I get this error:

Traceback (most recent call last):
  File "/usr/bin/salt-call", line 11, in <module    
    salt_call()
  File "/usr/lib/pymodules/python2.7/salt/scripts.py", line 76, in salt_call
    client.run()
  File "/usr/lib/pymodules/python2.7/salt/cli/__init__.py", line 257, in run
    caller.run()
  File "/usr/lib/pymodules/python2.7/salt/cli/caller.py", line 163, in run
    ret = self.call()
  File "/usr/lib/pymodules/python2.7/salt/cli/caller.py", line 76, in call
    ret['return'] = func(*args, **kwargs)
  File "/usr/lib/pymodules/python2.7/salt/modules/cp.py", line 203, in get_url
    return __context__['cp.fileclient'].get_url(path, dest, False, env)
  File "/usr/lib/pymodules/python2.7/salt/fileclient.py", line 344, in get_url
    raise MinionError('Error reading {0}: {1}'.format(url, ex.reason))
salt.exceptions.MinionError: Error reading https://username:password@ppa.mydomain.com:443/remote.key [Errno -2] Name or service not known

I think this might be due to urllib2.urlopen not liking my URL, but I can't be sure. I am Salt 0.15.3 on Ubuntu 12.04.

Specially I am trying to use this as the key_url in the pkgrepo state. I think this might of worked before the fix for #3894.

[basepi]

Whether your URL is valid or not, we definitely don't like tracebacks. We'll look into it.

[jlisee]

Thanks for the quick feedback. I should of mentioned that the URL itself works fine in other tools like wget and firefox.

[thatch45]

Looks like this is a limitation in the python urllib libs, we will need to handle this case in a different way