[BUG] Salt on stock macOS triggers Command Line Developer Tools GUI dialog #58575
Labels
Bug
broken, incorrect, or confusing behavior
MacOS
pertains to the OS of fruit
Magnesium
Mg release after Na prior to Al
severity-medium
3rd level, incorrect or bad functionality, confusing and lacks a work around
Milestone
Description
macOS unfortunately ships without git (among other standard dev tools). Compounding this nuisance, macOS does ship with a stub in place that, when executed, triggers a GUI dialog prompting the user to download the Command Line Developer Tools (CLT) package via Software Update.
For our use case, managing client endpoints we are forced to first install the CLT package ahead of Salt, which does the main work of bootstrapping devices. The CLT package is strangely very costly timewise to install, and this is avoidable since the only real use of its deliverables is when Salt imports the gitpython package as part of the gitfs utils to determine which version of git may be present.
Setup
No special setup required.
Steps to Reproduce the behavior
sudo salt-call --local test.sls
(state file doesn't even have to exist).Expected behavior
Salt should test for whether git is actually installed on macOS/Darwin prior to trying to use the git python package for determining version. In this situation, it is not installed and will not be available during the current salt run.
Screenshots
Versions Report
This has been an issue for Salt across numerous versions.
Additional context
I have a PR in progress to resolve this issue.
The text was updated successfully, but these errors were encountered: