Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Salt on stock macOS triggers Command Line Developer Tools GUI dialog #58575

Closed
sheagcraig opened this issue Sep 28, 2020 · 3 comments · Fixed by #58581
Closed

[BUG] Salt on stock macOS triggers Command Line Developer Tools GUI dialog #58575

sheagcraig opened this issue Sep 28, 2020 · 3 comments · Fixed by #58581
Assignees
Labels
Bug broken, incorrect, or confusing behavior MacOS pertains to the OS of fruit Magnesium Mg release after Na prior to Al severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Milestone

Comments

@sheagcraig
Copy link
Contributor

Description
macOS unfortunately ships without git (among other standard dev tools). Compounding this nuisance, macOS does ship with a stub in place that, when executed, triggers a GUI dialog prompting the user to download the Command Line Developer Tools (CLT) package via Software Update.

For our use case, managing client endpoints we are forced to first install the CLT package ahead of Salt, which does the main work of bootstrapping devices. The CLT package is strangely very costly timewise to install, and this is avoidable since the only real use of its deliverables is when Salt imports the gitpython package as part of the gitfs utils to determine which version of git may be present.

Setup
No special setup required.

Steps to Reproduce the behavior

  1. Install macOS afresh.
  2. Install macOS Salt package.
  3. sudo salt-call --local test.sls (state file doesn't even have to exist).

Expected behavior
Salt should test for whether git is actually installed on macOS/Darwin prior to trying to use the git python package for determining version. In this situation, it is not installed and will not be available during the current salt run.

Screenshots

Versions Report
This has been an issue for Salt across numerous versions.

Additional context
I have a PR in progress to resolve this issue.

@sheagcraig sheagcraig added the Bug broken, incorrect, or confusing behavior label Sep 28, 2020
@sheagcraig
Copy link
Contributor Author

@weswhet

@sagetherage sagetherage added needs-triage MacOS pertains to the OS of fruit labels Sep 28, 2020
@sagetherage
Copy link
Contributor

I can help with getting this triaged @sheagcraig and @weswhet let me know the PR in progress

@sagetherage sagetherage self-assigned this Sep 29, 2020
@sagetherage sagetherage added severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around and removed needs-triage labels Sep 29, 2020
@sagetherage sagetherage added this to the Approved milestone Sep 29, 2020
@sheagcraig
Copy link
Contributor Author

Thanks @sagetherage

#58581

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior MacOS pertains to the OS of fruit Magnesium Mg release after Na prior to Al severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants