Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some modules.rbenv funcs don't cope w/ failure cases #5888

Closed
cvrebert opened this issue Jul 2, 2013 · 0 comments · Fixed by #5893
Closed

some modules.rbenv funcs don't cope w/ failure cases #5888

cvrebert opened this issue Jul 2, 2013 · 0 comments · Fixed by #5893
Labels
Bug broken, incorrect, or confusing behavior help-wanted Community help is needed to resolve this severity-low 4th level, cosemtic problems, work around exists
Milestone
0.17.0

Comments

@cvrebert
Copy link
Contributor

cvrebert commented Jul 2, 2013 

************* Module salt.modules.rbenv
E1103:184,11:versions: Instance of 'bool' has no 'splitlines' member (but some types could not be inferred)
E1103:207,15:default: Instance of 'bool' has no 'strip' member (but some types could not be inferred)
E1103:219,16:list_: Instance of 'bool' has no 'splitlines' member (but some types could not be inferred)

_rbenv_exec() returns False when it fails; these functions assume it always returns a string, so they'll crash if they get False.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug broken, incorrect, or confusing behavior help-wanted Community help is needed to resolve this severity-low 4th level, cosemtic problems, work around exists
Projects
None yet
Milestone
0.17.0
Development

Successfully merging a pull request may close this issue.

Fix potential tracebacks when _rbenv_exec() returns False terminalmage/salt
1 participant
@cvrebert