Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Extend OpenVSwitch modules with VLAN and DB functions #58986

Closed
smarsching opened this issue Nov 19, 2020 · 0 comments · Fixed by #58987
Closed

[FEATURE REQUEST] Extend OpenVSwitch modules with VLAN and DB functions #58986

smarsching opened this issue Nov 19, 2020 · 0 comments · Fixed by #58987
Assignees
Labels
Feature new functionality including changes to functionality and code refactors, etc. master-port Sulfur v3006.0 release code name and version

Comments

@smarsching
Copy link
Contributor

The OpenVSwitch modules do currently not provide functions for adding bridges that are children of an existing bridge and use a specific VLAN tag. They do not provide functions for setting arbitrary properties (e.g. setting a fixed MAC address for an interface) either.

Therefore the following changes are needed:

  • Modify salt.states.openvswitch_bridge.present(…), adding two new optional parameters for the parent bridge and VLAN ID.
  • Modify salt.modules.openvswitch.bridge_create(…), so that it takes two new optional parameters for the parent bridge and VLAN ID. This function is used by salt.states.openvswitch_bridge.present(…).
  • Add a function bridge_to_parent(…) to salt.modules.openvswitch. This function is used to determine the parent of an existing bridge.
  • Add a function bridge_to_vlan(…) to salt.modules.openvswitch. This function is used to determine the VLAN ID of an existing bridge.
  • Add a module salt.states.openvswitch_db with a managed(…) function. This function can be used to make sure that a record in the OpenVSwitch database has certain values.
  • Add a function db_get to salt.modules.openvswitch. This function is used to read a value from the OpenVSwitch database.
  • Add a function db_set to salt.modules.openvswitch. This function is used to write a value to the OpenVSwitch database.

All these changes have been accepted into Salt before with PR #50564. However, this PR was made against the develop branch and they never got merged into master and thus never made it into a release.

I have now ported these changes to the current master and also made adjustments to make them fit the current guidelines (for example I added tests for all added or modified functions).

I will create a new PR with these changes soon. This issue has only been created to have an issue ID that can be referenced in the changelog entry.

@smarsching smarsching added the Feature new functionality including changes to functionality and code refactors, etc. label Nov 19, 2020
@waynew waynew added this to the Approved milestone Dec 15, 2020
@sagetherage sagetherage assigned dmurphy18 and unassigned waynew May 19, 2021
@dmurphy18 dmurphy18 changed the title Extend OpenVSwitch modules with VLAN and DB functions [FEATURE REQUEST] Extend OpenVSwitch modules with VLAN and DB functions Oct 14, 2021
@dmurphy18 dmurphy18 added the Sulfur v3006.0 release code name and version label Mar 30, 2022
@dmurphy18 dmurphy18 modified the milestones: Approved, Sulphur v3006.0 Mar 30, 2022
smarsching added a commit to smarsching/salt that referenced this issue Dec 9, 2022
This adds the new openvswitch_db state module. It also  adds the new
functions bridge_to_parent, bridge_to_vlan, db_get, and db_set to the
openvswitch execution module.

Besides, it adds two new optional parameters parent and vlan to the
openvswitch_bridge.present state module function and the
openvswitch.bridge_create execution module function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature new functionality including changes to functionality and code refactors, etc. master-port Sulfur v3006.0 release code name and version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants