return format of publish.publish changed

[ahammond]

When calling sudo salt-call publish.publish api01 grains.item datacenter I used to get

api01:
    rackspace

Following 0.16.0, I get

api01:
    ----------
    out:
        grains
    ret:
        ----------
        datacenter:
            rackspace

[ahammond]

Ooooh, and it changes depending on what command I publish:

sudo salt-call publish.publish api01 network.ip_addrs

pre 0.16.0:

api01:
    - 10.177.219.117
    - 174.143.143.32

post 0.16.0:

api01:
    ----------
    ret:
        - 10.177.219.117
        - 174.143.143.32

[terminalmage]

This looks to be a byproduct of some serialization changes. @thatch45, can you confirm, and if this is the case update the docstring(s) in the publish module to reflect the changes, to help clear up some of the confusion?

[ahammond]

@thatch any movement on this? It broke most of the states I have that use publish.publish. Well, all of them that use publish.publish for anything more than "get a list of servers that have this grain". Which is a shame since 0.16.0 fixed publish.publish enough that I could actually use it except for this.

[ahammond]

So... should I be updating all my states to reflect this change in return format, or... is this (as it appears to me), a bug? I see the Expected Behavior label on this but would really like a confirmation one way or the other...

[terminalmage]

Sorry @ahammond, @thatch45 has been traveling a lot and has been catching up on emails. I'll try to get ahold of him and bring this up.

[thatch45]

I am really sorry I have not taken care of this yet, the output should not change, I will get this taken care of ASAP

[thatch45]

@basepi, we need to get this into 0.16.1

[basepi]

Cherry-picked.

[ahammond]

@thatch45 thanks man! I really appreciate getting this fixed and in!!! :)