Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pip.installed doesn't allow empty (or omitted) name when using editable #6025

Closed
kevinastone opened this issue Jul 8, 2013 · 0 comments · Fixed by #6037
Closed

pip.installed doesn't allow empty (or omitted) name when using editable #6025

kevinastone opened this issue Jul 8, 2013 · 0 comments · Fixed by #6037
Assignees
@terminalmage
Labels
Bug broken, incorrect, or confusing behavior severity-low 4th level, cosemtic problems, work around exists
Milestone
0.17.0

Comments

@kevinastone
Copy link
Contributor

The following should work to install your packages locally (ala python setup.py develop see pip docs):

local_package_install:
    pip.installed:
        - editable: /dir/to/package

which should call the corresponding pip command

pip install --editable=/dir/to/package

But pip.installed always expects a valid name parameter and only empties it if a requirements file is supplied (here).
@ghost ghost assigned terminalmage Jul 8, 2013
terminalmage added a commit to terminalmage/salt that referenced this issue Jul 8, 2013
@terminalmage
Do not specify "name" when using pip install --editable
d6b6572 
This fixes saltstack#6025 by setting "name" to an empty string if the "editable"
param is used, like is already being done for the "requirements" param.
@terminalmage terminalmage mentioned this issue Jul 8, 2013
Merged
terminalmage added a commit to terminalmage/salt that referenced this issue Jul 8, 2013
@terminalmage
Do not specify "name" when using pip install --editable
525d55b 
This fixes saltstack#6025 by setting "name" to an empty string if the "editable"
param is used, like is already being done for the "requirements" param.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terminalmage terminalmage

Labels
Bug broken, incorrect, or confusing behavior severity-low 4th level, cosemtic problems, work around exists
Projects
None yet
Milestone
0.17.0
Development

Successfully merging a pull request may close this issue.

Do not specify "name" when using pip install --editable terminalmage/salt
2 participants
@terminalmage @kevinastone