Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Believes Git fileserver is enabled, when it isn't #6052

Closed
akoumjian opened this issue Jul 8, 2013 · 5 comments · Fixed by #6066
Closed

Believes Git fileserver is enabled, when it isn't #6052

akoumjian opened this issue Jul 8, 2013 · 5 comments · Fixed by #6066
Assignees
@terminalmage
Milestone
0.17.0

Comments

@akoumjian
Copy link
Contributor

After upgrading to 0.16.0, I noticed my master/minion logs started showing this error:

2013-07-08 20:24:35,112 [salt.loaded.int.pillar.git_pillar][ERROR   ] Git fileserver backend is enabled in configuration but could not be loaded, is git-python installed?

I do have my file server stored in git, but I am not using the git backend. My config files are pretty old (created somewhere in 10.2), but it doesn't state anything about which file server backend to use.

I'm thinking salt is seeing that the file root is in a git repo, and is assuming that I want to use the git backend when in fact I do not.
@terminalmage
Copy link
Contributor

Try running salt hostname pillar.data master and look for the fileserver_backend value. It should default to a list with a single element, "roots", which is the default fileserver backend, if nothing is specified in the master config.

@akoumjian
Copy link
Contributor Author

Yes, I am getting 'roots' as the value there.

fileserver_backend:
    - roots

So the question remains why am I getting that error.

@terminalmage
Copy link
Contributor

OK. In that case, salt is probably just indiscriminately trying to load all backend modules, irrespective of configuration. The error you're seeing comes from an attempt to import git that failed.

I'll dig a bit to try and see how salt loads the fileserver backends. Thanks for reporting.

@ghost ghost assigned terminalmage Jul 9, 2013
@terminalmage terminalmage mentioned this issue Jul 9, 2013
Merged
terminalmage added a commit to terminalmage/salt that referenced this issue Jul 9, 2013
@terminalmage
Don't try to load git_pillar if not enabled in master config
4225337 
This fixes saltstack#6052 by doing a check for git-based external pillars in the
master config, and returning False when there are none. This suppresses
an error later on in the __virtual__() function which complains that the
git fileserver backend is configured (when it clearly is not).
@terminalmage
Copy link
Contributor

@akoumjian Got a pull req (#6066) pending that fixes this. Thanks again for the report.

@akoumjian
Copy link
Contributor Author

Thank you for looking into it.

terminalmage added a commit that referenced this issue Jul 9, 2013
@terminalmage
Don't try to load git_pillar if not enabled in master config
9ec5eba 
This fixes #6052 by doing a check for git-based external pillars in the
master config, and returning False when there are none. This suppresses
an error later on in the __virtual__() function which complains that the
git fileserver backend is configured (when it clearly is not).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terminalmage terminalmage

Labels
None yet
Projects
None yet
Milestone
0.17.0
Development

Successfully merging a pull request may close this issue.

Don't try to load git_pillar if not enabled in master config terminalmage/salt
2 participants
@terminalmage @akoumjian