Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supervisord.running Returns Errors on test=True #6053

Closed
kevinastone opened this issue Jul 8, 2013 · 1 comment · Fixed by #6059
Closed

supervisord.running Returns Errors on test=True #6053

kevinastone opened this issue Jul 8, 2013 · 1 comment · Fixed by #6059
Assignees
@terminalmage
Labels
Bug broken, incorrect, or confusing behavior severity-low 4th level, cosemtic problems, work around exists
Milestone
0.17.0

Comments

@kevinastone
Copy link
Contributor

supervisord.running returns invalid response when running with test=True

Here's an example response:


----------
    State: - supervisord
    Name:      celery
    Function:  running
        Result:    False
        Comment:   An exception occurred in this state: Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.7/salt/state.py", line 1204, in call
    self.verify_ret(ret)
  File "/usr/lib/pymodules/python2.7/salt/state.py", line 580, in verify_ret
    'Malformed state return, return must be a dict'
SaltException: Malformed state return, return must be a dict

        Changes:   
----------

Looks like the return value is missing
@ghost ghost assigned terminalmage Jul 9, 2013
terminalmage added a commit to terminalmage/salt that referenced this issue Jul 9, 2013
@terminalmage
Fix return statement in supervisord.running state
cadd842 
When test=True is used, this state builts the return dict, and then runs
"return" instead of returning the dict, causing a traceback. This commit
fixes saltstack#6053 by fixing that return statement.
@terminalmage terminalmage mentioned this issue Jul 9, 2013
Merged
@terminalmage
Copy link
Contributor

Thanks for the report, fixed in #6059.

terminalmage added a commit that referenced this issue Jul 9, 2013
@terminalmage
Fix return statement in supervisord.running state
a4a90c2 
When test=True is used, this state builts the return dict, and then runs
"return" instead of returning the dict, causing a traceback. This commit
fixes #6053 by fixing that return statement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terminalmage terminalmage

Labels
Bug broken, incorrect, or confusing behavior severity-low 4th level, cosemtic problems, work around exists
Projects
None yet
Milestone
0.17.0
Development

Successfully merging a pull request may close this issue.

Fix return statement in supervisord.running state terminalmage/salt
2 participants
@terminalmage @kevinastone