Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] ethtool execution and state module functions for pause #63128

Closed
nicholasmhughes opened this issue Nov 28, 2022 · 0 comments · Fixed by #63129
Closed

[FEATURE REQUEST] ethtool execution and state module functions for pause #63128

nicholasmhughes opened this issue Nov 28, 2022 · 0 comments · Fixed by #63129
Labels
Execution-Module Feature new functionality including changes to functionality and code refactors, etc. State-Module

Comments

@nicholasmhughes
Copy link
Collaborator

Describe the solution you'd like
The current ethtool execution and state modules do not support pause features. Would like the equivalent of the -a and -A parameters to ethtool.

Describe alternatives you've considered
cmd.run...

Additional context
The ethtool Python module (https://pypi.org/project/ethtool/) on which the current functionality is based does not support pause features either... and it's deprecated. The project is recommended migration to netifaces (https://pypi.org/project/netifaces/), but that module lost its primary maintainer and the GitHub repo has been archived. Building functionality around ethtool binary returns might be prudent. Grabbing the parser code from insights-core is an easy way to interpret the results as a dict.

Please Note
If this feature request would be considered a substantial change or addition, this should go through a SEP process here https://github.com/saltstack/salt-enhancement-proposals, instead of a feature request.

@nicholasmhughes nicholasmhughes added Feature new functionality including changes to functionality and code refactors, etc. Execution-Module State-Module labels Nov 28, 2022
nicholasmhughes added a commit to nicholasmhughes/salt that referenced this issue Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Execution-Module Feature new functionality including changes to functionality and code refactors, etc. State-Module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant