-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] lgpo.set fails to set bool elements when mixed in with enums in 3005.1 #63473
Comments
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
Just ran on a new VM:
Probably needs an update... I'll try again after patching the system. |
Running the same SLS on a Windows Server 2019 VM with Salt 3005.1
Downgraded to Salt 3004.2 and re-running the same SLS:
Changing up the SLS a bit and adding some True boolean settings:
Running it with Salt 3005.1:
|
I'm seeing issues similar to this with salt 3005.1 and Windows 2022 Server, but not necessarily as stated in this issue's title. Mixed enums and bools has seemed to be configured correctly, with the following state file. test_configure_automatic_updates.sls
I see the following output
However, a re-application of the state throws an error (though the policy remains unchanged).
The fact that the "Every week", "First week of the month", etc. boolean keys don't show up in the salt state changes from the first state run, seems noteworthy, and potentially a source of this error. |
The above PRs should fix this issue |
Description
When using
lgpo.set
to set a mix ofenum
andbool
elements only the enum elements are set. This was working properly in Salt 3004.1. For example:Would result in:
Setup
Steps to Reproduce the behavior
SLS file
configure_automatic_updates.sls
:salt 'window-minions.*' state.apply configure_automatic_updates
Expected behavior
lgpo.set
should set bothenum
andbool
elements on the policy.Screenshots
If applicable, add screenshots to help explain your problem.
Versions Report
salt --versions-report
(Provided by running salt --versions-report. Please also mention any differences in master/minion versions.)Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: