Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state.module.run fails to recognize arguments m_name and m_fun #6464

Closed
andersbetner opened this issue Jul 31, 2013 · 3 comments
Closed

state.module.run fails to recognize arguments m_name and m_fun #6464

andersbetner opened this issue Jul 31, 2013 · 3 comments
Labels
Bug broken, incorrect, or confusing behavior Regression The issue is a bug that breaks functionality known to work in previous releases. severity-low 4th level, cosemtic problems, work around exists
Milestone

Comments

@andersbetner
Copy link
Contributor

From the mailing list https://groups.google.com/forum/#!topic/salt-users/zNV6lvNJuXU

I have this sls file:

tv_agent_restart:
  module:
    - run
    - name: supervisord.restart
    - m_name: tv_agent.py

And I get this as the result from a state.highstate

State: - module
Name:      supervisord.restart
Function:  run
    Result:    False
    Comment:   The following arguments are missing: m_name
    Changes:   

This is what the log looks like:

[DEBUG   ] Rendered data from file: /var/cache/salt/minion/files/base/agents/raspberrypi.sls:
tv_agent_restart:
  module:
    - run
    - name: supervisord.restart
    - m_name: tv_agent.py

[DEBUG   ] Results of YAML rendering: 
{'tv_agent_restart': {'module': ['run', {'name': 'supervisord.restart'}, {'m_name': 'tv_agent.py'}]}}
[INFO    ] Executing state module.run for supervisord.restart
[ERROR   ] No changes made for supervisord.restart
[INFO    ] Returning information for job: 20130730220833137956

The command:

sudo salt raspberrypi supervisord.restart tv_agent.py

forces supervisord to restart tv_agent.py without any problem.

@basepi
Copy link
Contributor

basepi commented Jul 31, 2013

Thanks for filing this. We will look into it.

@basepi
Copy link
Contributor

basepi commented Jul 31, 2013

Haven't verified that this is a regression, but it certainly looks like one. Labeled as such.

thatch45 added a commit that referenced this issue Aug 1, 2013
terminalmage added a commit to terminalmage/salt that referenced this issue Aug 1, 2013
terminalmage pushed a commit that referenced this issue Aug 1, 2013
Add fix for #6464 to 0.16.2 release notes
@terminalmage
Copy link
Contributor

Pull req #6479 was merged, fixing the issue. Marking resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Regression The issue is a bug that breaks functionality known to work in previous releases. severity-low 4th level, cosemtic problems, work around exists
Projects
None yet
Development

No branches or pull requests

3 participants