Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] follow_symlinks for file.symlink #64665

Closed
nicholasmhughes opened this issue Jul 18, 2023 · 0 comments · Fixed by #64666
Closed

[FEATURE REQUEST] follow_symlinks for file.symlink #64665

nicholasmhughes opened this issue Jul 18, 2023 · 0 comments · Fixed by #64666
Assignees
Labels
Execution-Module Feature new functionality including changes to functionality and code refactors, etc.

Comments

@nicholasmhughes
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
file.symlink always follows symlinks as it uses os.path.exists() here. This causes performance issues on remote sites when we create symlinks of NFS directories.

Describe the solution you'd like
os.path.lexists() will not follow links during existence checks. Using that function is probably the easiest way to accommodate the requirement.

Describe alternatives you've considered
N/A

Please Note
If this feature request would be considered a substantial change or addition, this should go through a SEP process here https://github.com/saltstack/salt-enhancement-proposals, instead of a feature request.

@nicholasmhughes nicholasmhughes added Feature new functionality including changes to functionality and code refactors, etc. Execution-Module labels Jul 18, 2023
@nicholasmhughes nicholasmhughes self-assigned this Jul 18, 2023
nicholasmhughes added a commit to nicholasmhughes/salt that referenced this issue Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Execution-Module Feature new functionality including changes to functionality and code refactors, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant