package_module.upgrade() API inconsistent

[cvrebert]

The API for the upgrade() function of package manager modules is inconsistent.

The following modules don't allow any argument to be passed to upgrade():

• freebsdpkg
• pacman
• pkgin

The following modules implement (at least) a refresh parameter:

• apt
• ebuild
• pkgutil
• win_pkg
• yumpkg
• yumpkg5
• zypper

The following modules have a **kwargs parameter, which they completely ignore:

• apt
• pkgutil

And pkgng is a real oddball: upgrade(jail=None, chroot=None, force=False, local=False, dryrun=False):

I would ask that the API be made more uniform.

[terminalmage]

There are other pending changes that we are considering for pkg providers, I'll address these concerns when I implement the changes.

In particular, freebsdpkg and pkgng need a lot of work. freebsdpkg contains a bunch of pkgng stuff that should be broken out into the pkgng module, so that they can both be distinct, with freebsdpkg handling traditional pkg_add installs and pkgng handling all pkgng installs.

[thatch45]

Based on the package re-factor I am going to close this out