Salt-ssh bug parsing command arguments

[stevearc]

I discovered this while trying to use cmd.run via salt-ssh. Using zmq, I do this:

root@salt~:$ salt salt cmd.run "echo 'hi'"
salt:
    hi

But when I use salt-ssh this happens

root@salt~:$ salt-ssh salt cmd.run "echo 'hi'"
salt:
    Pseudo-terminal will not be allocated because stdin is not a terminal.
    stdin: is not a tty
    Error running 'cmd.run': Specified cwd 'hi' either not absolute or does not exist

This happens because the second positional argument to cmd.run is the cwd. I assume that it's probably the argument parser that's broken, though I suppose it could also be the salt ssh client?

version report:

           Salt: 0.17.0
         Python: 2.7.3 (default, Sep 26 2013, 20:03:06)
         Jinja2: 2.7.1
       M2Crypto: 0.21.1
 msgpack-python: 0.1.10
   msgpack-pure: Not Installed
       pycrypto: 2.4.1
         PyYAML: 3.10
          PyZMQ: 13.0.0
            ZMQ: 3.2.2

[stevearc]

This might be the same problem as #7698

[basepi]

Possible. Could you please test with the latest develop branch of with the newly-released 0.17.1 release? Curious if it's still an issue, there's been a lot of churn in salt-ssh since it was released.

[stevearc]

Just tested on most recent develop and 0.17 branches, and the bug is still present in both of them.

Develop was at: 0.17.0-1299-g5f8b2a4
0.17 was at: 0.17.1

[basepi]

Thanks for the report. This might be a salt problem, rather than just a salt-ssh problem, with the changes to how commands are run that @UtahDave added recently.

[basepi]

Oh nevermind, those changes weren't present in 0.17.0. Anyway, we'll get this fixed.