Postgres state doesn't return failure if postgres module returns failure for some states

[dknecht]

An example is if a user is failed to be created the state always returns success.

the module returns an error but doesn't return failture error code to state:

(db)25db2:/home/dane# salt-call postgres.user_create  'dane'
[INFO    ] Executing command 'psql --no-align --no-readline --username postgres --port 5432 --dbname postgres -c \'SELECT setting FROM pg_catalog.pg_settings WHERE name = \'"\'"\'server_version\'"\'"\'\' -t' as user 'postgres' in directory '/home/postgres'
[INFO    ] Executing command 'psql --no-align --no-readline --username postgres --port 5432 --dbname postgres -v datestyle=ISO,MDY -c \'COPY (SELECT rolname as "name", rolsuper as "superuser", rolinherit as "inherits privileges", rolcreaterole as "can create roles", rolcreatedb as "can create databases", rolcatupdate as "can update system catalogs", rolcanlogin as "can login", rolreplication as "replication", rolconnlimit as "connections", rolvaliduntil::timestamp(0) as "expiry time", rolconfig  as "defaults variables" FROM pg_roles) TO STDOUT WITH CSV HEADER\'' as user 'postgres' in directory '/home/postgres'
[INFO    ] Executing command 'psql --no-align --no-readline --username postgres --port 5432 --dbname postgres -c \'CREATE USER "dane"\'' as user 'postgres' in directory '/home/postgres'
local:
    ERROR:  cannot execute CREATE ROLE in a read-only transaction

[basepi]

So you're just talking about the return code? That is by design -- the retcode is designed to just tell whether salt executed successfully, it doesn't have any bearing on whether the states/modules were successful or not.

There are a few open issues for a flag to change this behavior. Also, salt-call has a --retcode-passthrough that might serve your purposes.

[dknecht]

So when this is run via a state:

frank:
postgres_user.present

it would show as successful even though the underlying action failed. I don't believe that is expected behavior. Shouldn't the state fail?

For most of the other postgres calls you return false when the command fails.

[basepi]

Ah, I didn't realize the states were returning False. You only showed a module example (and I missed it in the title.)

Should be easy to fix, thanks for the report.

[basepi]

Can you add sample output of that state you posted above? Exact error messages and so forth help track down the exact location in the code faster.

[dknecht]

It just returns successful.

In the role create you just return regardless...
https://github.com/saltstack/salt/blob/develop/salt/modules/postgres.py#L547

In other posgres commands you check the return value...
https://github.com/saltstack/salt/blob/develop/salt/modules/postgres.py#L368