Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fileclient from urllib2 to requests #11708

Merged
merged 1 commit into from Apr 2, 2014

Conversation

techhat
Copy link
Contributor

@techhat techhat commented Apr 1, 2014

This makes requests a hard dependency for Salt.

This should only be merged by @thatch45.

@basepi, please do not cherry pick.

@ghost
Copy link

ghost commented Apr 1, 2014

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/2970/

thatch45 added a commit that referenced this pull request Apr 2, 2014
Change fileclient from urllib2 to requests
@thatch45 thatch45 merged commit 2b5c31a into saltstack:develop Apr 2, 2014
@techhat techhat deleted the fileclient branch April 2, 2014 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants