Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't trace on IOErrors #11892

Merged
merged 3 commits into from Apr 10, 2014
Merged

Conversation

s0undt3ch
Copy link
Member

Refs #11783, #11853

@s0undt3ch
Copy link
Member Author

Need to bring @basepi and @rallytime into the conversation.

@s0undt3ch
Copy link
Member Author

The reason why I'm not exiting like @basepi suggests on #11783 is because, as you might see on the logs, if the configuration file is not found or readable, the configuration defaults is what's used. This has been the default behaviour thus far.

If we need to exit on unreadable configuration files, which might be an unexpected "bahaviour" change(from the user's perspective), then we should probably ask @thatch45 about this, and, as I talked about in #11852, that should be done in parsers, and would be done way sooner than that stack trace.

Thoughts?

@ghost
Copy link

ghost commented Apr 9, 2014

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/3226/

@s0undt3ch s0undt3ch closed this Apr 9, 2014
@s0undt3ch s0undt3ch reopened this Apr 9, 2014
@ghost
Copy link

ghost commented Apr 9, 2014

Test PASSed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/3227/

@rallytime
Copy link
Contributor

@s0undt3ch - This solution looks much simpler! Looks good to me unless @thatch45 has any concerns.

thatch45 added a commit that referenced this pull request Apr 10, 2014
@thatch45 thatch45 merged commit a328e4a into saltstack:develop Apr 10, 2014
@thatch45
Copy link
Member

Thanks @s0undt3ch , this looks awesome!

@s0undt3ch
Copy link
Member Author

Anytime!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZZZ[Done]-back-ported-bf RETIRED The pull request has been back-ported to an older branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants