New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't trace on IOErrors #11892
Don't trace on IOErrors #11892
Conversation
This reverts commit 79b5e46.
The file might exist, we just might not be able to read it. Refs saltstack#11783.
Need to bring @basepi and @rallytime into the conversation. |
The reason why I'm not exiting like @basepi suggests on #11783 is because, as you might see on the logs, if the configuration file is not found or readable, the configuration defaults is what's used. This has been the default behaviour thus far. If we need to exit on unreadable configuration files, which might be an unexpected "bahaviour" change(from the user's perspective), then we should probably ask @thatch45 about this, and, as I talked about in #11852, that should be done in parsers, and would be done way sooner than that stack trace. Thoughts? |
Test Failed. If the failures are unrelated to your code, don't stress, a core developer will know these apart. |
Test PASSed. |
@s0undt3ch - This solution looks much simpler! Looks good to me unless @thatch45 has any concerns. |
Thanks @s0undt3ch , this looks awesome! |
Anytime! |
Refs #11783, #11853