New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit of boto_sqs state and module #12101
Conversation
This state and module manage SQS queues via boto, rather than the aws commands. Since it's using boto, it supports IAM instance profile credentials natively. The module and state also support the ability to accept key/keyid credentials as parameters, through pillars or through minion configuration. In addition, the state and module supports managing queue attributes. In the state this is added as an argument. In the module it's a separate function. The module also has support for fetching the attributes for a queue.
Test PASSed. |
This is awesome stuff, @ryan-lane. But can I offer a suggestion before we merge it? Take a look at the recent etcd additions (utils, modules, pillar, returners). The way I've set up the configuration allows for a single account to be used as you've done here, or for multiple accounts to be configured and used (which is the norm in an AWS environment) depending on which one is appropriate at the time. What do you think? |
Ah. Cool. That does indeed look nicer. It also means that I could share the same set of credentials across all aws services. |
Test Failed. If the failures are unrelated to your code, don't stress, a core developer will know these apart. |
Test PASSed. |
That looks awesome, @ryan-lane. One more thought: how do you feel about calling your states |
I'm fine with that. I'll push in a fix. |
Test Failed. If the failures are unrelated to your code, don't stress, a core developer will know these apart. |
Test Failed. If the failures are unrelated to your code, don't stress, a core developer will know these apart. |
Test Failed. If the failures are unrelated to your code, don't stress, a core developer will know these apart. |
Test Failed. If the failures are unrelated to your code, don't stress, a core developer will know these apart. |
Initial commit of boto_sqs state and module
This state and module manage SQS queues via boto, rather than the
aws commands. Since it's using boto, it supports IAM instance profile
credentials natively. The module and state also support the ability
to accept key/keyid credentials as parameters, through pillars or
through minion configuration.
In addition, the state and module supports managing queue attributes.
In the state this is added as an argument. In the module it's a separate
function. The module also has support for fetching the attributes for a
queue.