Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra handling to highstate outputter for 'Comment' #12844

Merged
merged 1 commit into from
May 17, 2014

Conversation

basepi
Copy link
Contributor

@basepi basepi commented May 16, 2014

Highstate outputter was handling strings in the comment, and lists, but wouldn't handle anything else. (In this case, the fix is for dicts, but it should fix for any data structure, assuming it has a defined string representation)

Really, states should not be outputting comments as dicts, and this may not look especially pretty, but it will not stacktrace and fallback to the default outputter. It will be up to the authors of those states to fix their comments to make them pretty.

Fixes #12840

@ghost
Copy link

ghost commented May 16, 2014

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/4425/

@basepi
Copy link
Contributor Author

basepi commented May 16, 2014

Failures unrelated to my code.

thatch45 added a commit that referenced this pull request May 17, 2014
Add extra handling to highstate outputter for 'Comment'
@thatch45 thatch45 merged commit 3111d1d into saltstack:develop May 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot get highstate style output with salt.states.tomcat.war_deployed
2 participants