Add extra handling to highstate outputter for 'Comment' #12844
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highstate outputter was handling strings in the comment, and lists, but wouldn't handle anything else. (In this case, the fix is for dicts, but it should fix for any data structure, assuming it has a defined string representation)
Really, states should not be outputting comments as dicts, and this may not look especially pretty, but it will not stacktrace and fallback to the default outputter. It will be up to the authors of those states to fix their comments to make them pretty.
Fixes #12840